Skip to content

package: Don't remove packages of other apps on uninstall

Sunil Mohan Adapa requested to merge sunilmohan/freedombox:dont-remove-other-apps-on-uninstall into master

Fixes: #2376 (closed). Fixes: #2317 (closed).

When an app is removed, its packages are purged. However, there is another installed app that needs these packages, we should keep those packages. We have already implemented checking the packages against other apps' packages. However, we are not checking if we are removing dependencies of other apps' packages. This will still result in removal apps' packages.

To solve this problem, get list of packages of all the apps, then iterate over their dependencies recursively and compile a comprehensive list of packages to keep. Use this to reduce the set of packages to remove.

Tests:

  • Without the patch, install bepasty and janus. Uninstall janus app and notice that bepasty package is removed. With the patch, the problem is not observed.

  • Printing the comprehensive list of packages to keep shows an extensive set computed.

Signed-off-by: Sunil Mohan Adapa sunil@medhas.org

Merge request reports