Skip to content

networks: Fix focusing on network interface field on error

Sunil Mohan Adapa requested to merge sunilmohan/freedombox:networks-fix-focus-on-select into main

  • In create/edit network connection form, if the accordion is closed for 'General' section, Network Interface has not be selected yet and Submit button is pressed, 'General' section should be expanded and focus should go to Network Interface field. This is not working as expected as the code to expand accordions didn't match 'select' type input fields properly. Fix this.

  • Declare a common class name for both create and edit forms to make writing queries easier.

  • Drop console logs that where meant for debugging.

Tests:

  • On both create and edit connection forms, set the value of network interface to '--select--' and collapse the 'General' section. Press submit. The 'General' section is expanded, Network Interface field is focus and scrolled into view.

  • Do the same check for another field such as Connection Name and that works too.

Signed-off-by: Sunil Mohan Adapa sunil@medhas.org

Merge request reports