Skip to content

Fix anonymous access to setup view

Sunil Mohan Adapa requested to merge SunilMohanAdapa:fix-setup-middlware into master

Created by: SunilMohanAdapa

Django runs process_request() on all the middleware classes in order. Then it runs process_view() on all of them again. During the runs, if any of the views return a HttpResponse. Further processing is ignored.

Setup middleware was handling process_request() and returning HttpResponse if the application as not setup. However, stronghold middleware handles process_view(). Since process_request happens first and response is being returned there, stronghold middleware is never called.

  • Make setup middleware use process_view() instead.
  • Make minor udpates
  • Test cases

Merge request reports