Skip to content

Firstboot fixes and refactoring

Sunil Mohan Adapa requested to merge SunilMohanAdapa:firstboot-fixes into master

Created by: SunilMohanAdapa

  • Fix major regression so that steps can submitted multiple times in case of errors.

  • Don't serve the welcome page (and other pages) only once. Show it until action is an taken. This does not apply to the final step.

  • Eliminate all coupling of one first boot step on another.

  • Move first boot helper methods to init.py instead of middleware as it is more generic than middleware.

  • Implement caching the first boot state to avoid an SQL query on every page load. The down side is that if first boot state is modified in the backend DB outside Plinth, Plinth will need to be restarted to catch the modified value.

  • Mark some methods as private.

  • Refactor middleware code for slightly more simplicity.

  • Don't show sidebar in pagekite first boot step. Set width like other pages.

  • pagekite: Fix first boot to use requests module

  • Rename views/urls to be non-numeric

  • Indentation & styling fixes

Merge request reports