Commits on Source (45)
-
Mark Reynolds authored
Bug Description: The first issue what the internal represenation of the default error code changed since the feature was added. This caused the disk monitoring thread to loop and never actually attempt to stop the server. The other issue is that with nunc-stans g_set_shutdown() is no longer stops the server. Fix Description: Change the defaulterror logging level to be more robust and accept all the default level values. Also, we needed to free the rotated logs when we delete them. Finally add raise() to g_set_downdow(), and make sure set_shutdown() does not overwrite the slapd_shutdown value. https://pagure.io/389-ds-base/issue/49734 Reviewed by: tbordaz & spichugi(Thanks!)1c5831c0 -
Mark Reynolds authored
Ticket 49751 - passwordMustChange attribute is not honored by a RO consumer if using "Chain on Update" Bug Description: For a chained bind request we do not check password policy, in particular if the password must be reset. Fix Description: For a chained bind request check if the password must be reset. This is the only password policy setting that must be applied on the connection itself. All other password policy is still enforced correctly. https://pagure.io/389-ds-base/issue/49751 Reviewed by: spichugi, tbordaz, and lkrispen(Thanks!!!)d2c26d89 -
Samuel Rakitničan authored87876bca
-
Mark Reynolds authored
Description: Changed the names of the two positional arguemnts from "fromfile" --> "install", and "example" --> "create-template" Added option for specifying template file instead of dumping the template to STDOUT Finally added autocomplete arg parsing to the cli tools, and used a unique file name in UI when creating template. https://pagure.io/389-ds-base/issue/49791 Reviewed by: ?749b9f33 -
Marc Muehlfeld authored
Description: This patch changes the format of the "dscreate example" output to: parameter_name (type) [REQUIRED|optional] Description: ... Default value: ... Additionally, the patch updates the parameter descriptions to be more descriptive. https://pagure.io/389-ds-base/issue/49793 Reviewed by: mreynolds Signed-off-by:Mark Reynolds <mreynolds@redhat.com>
fa41aee9 -
Viktor Ashirov authored
Another round of py3 fixes for tests in tickets/. https://pagure.io/389-ds-base/issue/49588 Reviewed by: mreynolds (Thanks!)
a2cbef23 -
Viktor Ashirov authored
Bug Description: From the test's output it's not possible to tell what version of 389-ds-base was used during the test, what are the versions of libraries that we depend on, etc. Fix Description: We can use conftest.py to print this useful information. This also will be reflected in an html report, if py.test is used with --html option. https://pagure.io/389-ds-base/issue/49717 Reviewed by: spichugi, amsharma, mreynolds (Thanks!)
08b2d884 -
Timo Aaltonen authored
Fix linking order of libldaputil/libslapd https://pagure.io/389-ds-base/issue/49816
126e700f -
Mark Reynolds authored
Description: This patch pulls in all the cn=config values and poplues the UI. it also allows you to save values to the server. Also cockpit can only pull in strerr messages when things fail, so I had to undue a recent change to redirect stderr to stdout. https://pagure.io/389-ds-base/issue/49783 Reviewed by: spichugi & vashirov(Thanks!!)eafaf473 -
Mark Reynolds authored
Bug Description: A recent man page scan revealed several errors and warnings. Fix Description: Added missing man pages, fixed syntax issues, and added new man pages for config files. Also added dynamic man page creation for the lib389 CLI tools using python-argparse-manpages https://pagure.io/389-ds-base/issue/49811 Reviewed by: spichugi & vashirov(Thanks!!)0d9886e7 -
Simon Pichugin authored
Description: Mark conflict resolution test cases as 'xfail' (ds49591). Fix SASL test. Fix Python 3 bytes issues in ds-replcheck tool. Roll back a part of the PBKDF2_SHA256 schema fix because upgrade fails without this part of the code. https://pagure.io/389-ds-base/issue/49761 Reviewed by: vashirov, mreynolds (Thanks!)
177f5c45 -
Mark Reynolds authored
Description: Update docker file to use new option names in dscreate ttps://pagure.io/389-ds-base/issue/49791 Review by mreynolds (one line commit rile)
d881a4cb -
Viktor Ashirov authored
Bug Description: python3-ldap [1] is not the same as python-ldap [2]. [1] https://pypi.org/project/python3-ldap/ [2] https://pypi.org/project/python-ldap/ Fix Description: Update setup.py and requirements.txt. https://pagure.io/389-ds-base/issue/49820 Reviewed by: mreynolds (Thanks!)
b903b039 -
Akshay Adhikari authored
Description: Added py3 support by explicitly changing strings to bytes. https://pagure.io/389-ds-base/issue/49588 Reviewed by: vashirov (Thanks!)
c0a80d28 -
Mark Reynolds authored
Description: Added the backend functionality for all the items in the "Action" dropdown list on the banner. Added ability to use the instance name in dsconf, previously only ldap URLs worked. Added more helper functions: popup_confirm() - this now accepts html tags so nicer output get_ldapurl_from_serverid(server_id) - take an instance name and generate a LDAP URL from its dse.ldif And of course did some code cleanup. https://pagure.io/389-ds-base/issue/49795 Reviewed by: ?f80928f4 -
Mark Reynolds authored
Description: Create and install the lib389 cli man pages in its setup.py file. Previously running "make" in a dev environment was failing because "make' was not installing lib389 (and its man pages) which was breaking the build. https://pagure.io/389-ds-base/issue/49811 Reviewed by: ?4404d03d -
Mark Reynolds authored
Description: Added new directives to the inf file to create multiple backends. Also update the UI for the new options. Also, changed some all the inf options to be optional except for the rootdn password. Did some other minor code cleanup https://pagure.io/389-ds-base/issue/49808 Reviewed by: vashirov, spichugi, and firstyear (Thanks!!!)ea7e9897 -
Mark Reynolds authored
Description: Added interactive installer to dscreate. Also added signal handlers so that control-c does not cause a python stack dump in the cli tools. Also quieted the output for dscreate, and made it slightly more friendly. https://pagure.io/389-ds-base/issue/49813 Reviewed by: spichugi(Thanks!)90332887 -
Mark Reynolds authored
Description: We now bundle jemalloc, so stop building the server with tcmalloc. https://pagure.io/389-ds-base/issue/49832 Reviewed by: mreynolds(one line commit rule)185963ef -
Mark Reynolds authored
Bug Description: The server was previously reserving the backend name "default". If you tried to import on a backend with this name the import would skip all child entries Fix Description: Change the default backend name to something obscure, instead of "default". Also improved lib389's dbgen to generate the correct "dc" attribute value in the root node. https://pagure.io/389-ds-base/issue/49830 Reviewed by: spichugi(Thanks!)8fa838a4 -
Ludwig Krispenz authored
Bug: There is a connection an operation extension to keep evaluation results cached across multiple operations. In the geteffective for each evaluation a sepatate temporary connection extension is created and freed. If there are several concurrent operations in one connection the operation extension destructor can try to access an already freed connection extension. Fix: Do not free the connectcion extension during the life time of a connection. If a temporary extension should be used, lock the connection extension, copy the content to a saved structure and copy the temporary data to the connection extension. When done with the temporary extension reverse this. To make this work the locks need to be directly created, the use of the limited preallocated array of locks could lead to a situation where both the main and the temporary extension would get the sam elock assigned. Reviewed by: Thierry and Mark, Thanks5537467e -
Thierry Bordaz authored
Ticket 48818 - For a replica bindDNGroup, should be fetched the first time it is used not when the replica is started Bug Description: The fetching of the bindDNGroup is working as designed but this ticket is to make it more flexible At startup, if the group does not contain the replica_mgr. No replication session will succeed until bindDnGroupCheckInterval delay. updatedn_group_last_check is the timestamp of the last fetch. At startup updatedn_group_last_check is set to the current time. So the next fetch will happen not before updatedn_group_last_check+bindDnGroupCheckInterval. If the groupDn is changed after startup, no incoming replication can happen for the first bindDnGroupCheckInterval seconds Fix Description: The fix consist to unset updatedn_group_last_check so that the group will be fetch when the first incoming replication session will happen. https://pagure.io/389-ds-base/issue/49818 Reviewed by: Mark Reynolds, Simon Spichugi (thanks !!!) Platforms tested: F27 Flag Day: no Doc impact: no
4206d278 -
Stanislav Laznicka authored
The python standard logging module allows to postpone the string interpolation in logs till the time the interpolation is actually needed (note that you may be running in a certain logging level that won't need to display/write all strings). This behavior is there to comply with the logging requirement so that logs don't affect the performance if no logging happens. The above behavior only works when strings are passed as arguments to the logging methods. If the interpolation is invoked at place either by using the `%` notation or by using the `str.format()` method, python logging can't perform its performance heuristics since the strings get interpolated before they are handed to the logging methods. This commit fixes the improper behavior observed in the lib389 library, plus adds some fixes to improper invokes of the logging methods - multiple arguments if formatting string does not contain formatting variables - which would cause internal logging errors that don't cause the scripts failures, which is why they probably weren't reported yet. https://pagure.io/389-ds-base/issue/49835 Reviewed by: mreynolds, spichugi Signed-off-by:
Simon Pichugin <simon.pichugin@gmail.com>
df95edbe -
Simon Pichugin authored
Bug Description: We add PBKDF2_SHA256 password storage schema two times. During: 1. the dse.ldif parsing; 2. the bootstrap plugin operation. It causes the error to appear during the startup. Fix Description: Make plugin_setup() function report the error to TRACE log level if the plugin already exists. We will report the error in ERR log level during the config bootstrap anyway (code path for the 1st option from bug description). For 2nd option, report the error to TRACE if it is 'already exist' issue and to ERR if it is any other case. Make the plugin_setup returns more consistent. https://pagure.io/389-ds-base/issue/49640 Reviewed by: mreynolds, mhonek (Thanks!)
2fa04088 -
Mark Reynolds authored
Ticket 49840 - ds-replcheck command returns traceback errors against ldif files having garbage content when run in offline mode Description: Added a basic check to see if the LDIF files are actually LDIF files. Also added checks that the database RUV are present as well. https://pagure.io/389-ds-base/issue/49840 Reviewed by: spichugi(Thanks!)60cb5204 -
Mark Reynolds authored
Description: Change dsMaxThreadsHit to dsMaxThreadsHits, and set the proper object type for dsIntIndex https://pagure.io/389-ds-base/issue/49546 Reviewed by: spichugi & firstyear(Thanks!!)6d4caac0 -
Amita Sharma authored
Description: Added a test test_memberof_group() to test bug1551071, it tests that memberof does not fail if group is moved into scope https://pagure.io/389-ds-base/issue/49161 Reviewed by: Simon
fbe62eb7 -
Stanislav Laznicka authored
Bug description: lib389 was calling `logging.basicConfig()` at several places at module scope level. This was causing imports from these modules to add an unwanted handler to the root logger of the python's standard logging module. Fix description: Set up logging only in the scripts that are using lib389. ALso, remove unused imports in __init__.py https://pagure.io/389-ds-base/issue/49844 Reviewed by: spichugi, mreynolds (Thanks!) Signed-off-by:
Simon Pichugin <spichugi@redhat.com>
7892486b -
Thierry Bordaz authored
Bug Description: By default, unhashed#user#password is recorded into changelog database. It is a specific use when some plugin need to know the clear text password on update. This should be disabled ('off') by default Fix Description: Switch the default value from 'on' to 'off' https://pagure.io/389-ds-base/issue/49789 Reviewed by: Viktor Ashirov, Simon Pichugi, Mark Reynolds Platforms tested: F27 Flag Day: no Doc impact: noe81fa859 -
Mark Reynolds authored
Description: Removed some advanced settings from the install questions. Moved the signal handlers to non-verbose runs. Fixed some mixed case issues. Added option for sample entries. Added "interactive" argument, and restored "fromfile" from "install". https://pagure.io/389-ds-base/issue/49813 Reviewed by: mmuehlfeldrh & spichugi(Thanks!!)4f5f6bb5 -
Mark Reynolds authored
Description: Move jemalloc license (COPYING.jemalloc) to /usr/share/licences also added nss version dependancy that was missing https://pagure.io/389-ds-base/issue/48377 Reviewed by: mreynolds(one line commit rule)9110d2b4 -
Mark Reynolds authored3fc43bdc
-
Mark Reynolds authored
Bug Description: If no instances are present when the legacy tool subpackage is installed the RPM scriplet throws an error: line 29: [: -eq: unary operator expected Fix Description: The error occurs because a variable that counts the existing instances is not initialized. https://pagure.io/389-ds-base/issue/49857 Reviewed by: mreynolds (one line commit rule)a9fa2104 -
Mark Reynolds authored
Description: This change broke FreeIPA, so for now we need to back it out https://pagure.io/389-ds-base/issue/49789
172c60a2 -
Mark Reynolds authored
Description: Add SASL functionality to dsconf and UI Improved installer to load the template-sasl ldif file. Also cleaned up some of the "clear form" functions to be more efficient using jquery. https://pagure.io/389-ds-base/issue/49806 Reviewed by: spichugi(Thanks!)ba5900ee -
Mark Reynolds authored
Description: dscreate was not creating its config file in /etc/tmpfiles.d/ like setup-ds.pl used to do. The absence of this config file prevented the server from being started after a reboot. https://pagure.io/389-ds-base/issue/49854 Reviewed by: vashirov(Thanks!)dd183895 -
Mark Reynolds authored345221c0
-
Timo Aaltonen authoredb7fe3ea9
-
Timo Aaltonen authoredf2254733
-
Timo Aaltonen authored
Revert "control: Drop 389-ds metapackage, the other 389-ds-* packages are EOL'd upsream and will be removed soon." This reverts commit bffa315b.
ee619c25 -
Timo Aaltonen authored
control: Modify 389-ds to depend on cockpit-389-ds and drop the old GUI packages which are deprecated upstream.
c1c67ef6 -
Timo Aaltonen authoreda9b1666d
-
Timo Aaltonen authored
dont-build-new-manpages.diff: Debian doesn't have argparse-manpage, so in order to not FTBFS don't build new manpages.
8f634923 -
Timo Aaltonen authored028dadcd
-
Timo Aaltonen authored222d75b7
debian/patches/dont-build-new-manpages.diff
0 → 100644
debian/patches/fix-linking.diff
deleted
100644 → 0
dirsrvtests/conftest.py
0 → 100644