Commits on Source (29)
-
Simon Pichugin authored
Description: dsconf tool now has: 'dsconf localhost backup create' and 'dsconf localhost backup restore'; 'dsconf localhost backend import' and 'dsconf localhost backend export'. Add basic tests for the CLI part Add JS logic for online backup/restore. Add more HTML and JS for online import/export functionality. Fix CSS alignment issues. Fix validity checks in CLI. https://pagure.io/389-ds-base/issue/49858 Reviewed by: mreynolds, wibrown, mhonek (Thanks!)
c393394f -
William Brown authored
When the SASL maps for single backend was made, it was assuming a number of behaviours such as a single backend was added. This is *not* the default in lib389, and caused a crashed when a valid ZERO backend server was created. Additionally, it used a template file that will not be present in the future. This Fixes the behaviour to account for 0, 1 and multiple backends and uses the correct saslmapping objects to create the types needed for LDAPI https://pagure.io/389-ds-base/issue/49887 Author: William Brown <william@blackhats.net.au>
d06b5bb2 -
Mark Reynolds authored
This reverts commit 5c89dd8f.
104968b6 -
Mark Reynolds authored
This reverts commit 4cd1a24b.
14a10a34 -
Mark Reynolds authoredde78c494
-
Mark Reynolds authored
Description: Add logic to get and save the access & errors log levels in the UI tables https://pagure.io/389-ds-base/issue/49877 Reviewed by: ?
09ad0d01 -
Simon Pichugin authored
Description: Refactor Password Policy module and its CLI part. Add PwPolicyManager object and PwPolicyEntry(DSLdapObject). Validate LDIF and Backup dir paths. Don't accept a forward slash because it can lead to a security flow. Add an additional assertion to Backup/Restore CLI test suite. https://pagure.io/389-ds-base/issue/49866 Reviewed by: mreynolds (Thanks!)
d6616221 -
Amita Sharma authored
Description: Added test cases for attribute encryption https://pagure.io/389-ds-base/issue/48053 Reviewed by: Simon and Viktor
2dc26d9b -
Mark Reynolds authored
Ticket 49932 - Crash in delete_passwdPolicy when persistent search connections are terminated unexpectedly Bug Description: We clone a pblock in a psearch search, and under certain error conditions this pblock is freed, but it frees the password policy struct which can lead to a double free when the original pblock is destroyed. Fix Description: During the cloning, set the pwppolicy struct to NULL so the clone allocates its own policy if needed https://pagure.io/389-ds-base/issue/49932 Reviewed by: ?
78fc627a -
Akshay Adhikari authored
Description: Fixed fixture names and also python3 issue. https://pagure.io/389-ds-base/issue/49930 Reviewed by: amsharma & spichugi (Thanks!)
8857b150 -
Mark Reynolds authored
Description: Typo in the pwdpolicy subentry attribute name https://pagure.io/389-ds-base/issue/49866 Reviewed by: mreynodls(one line commit rule)
c64f7fb1 -
Mark Reynolds authored
Bug Description: Multiple operations making modificatiosn on a DN that is very large can crash the server, because when we do emergency logging, we close and reopen the errors log withgout hold the error log write lock. This causes the FD pointer to be become invalid and triggers a crash. Fix description: Hold the errors log write lock while closing and reopening the log https://pagure.io/389-ds-base/issue/49937 Reviewed by: vashirov(Thanks!)
8ff8cb85 -
William Brown authored
Clean the thread local usage of the logging system to be more inline with pthread's intent, remove bad practices of case/switch get setters, and change the types to be more effecient struct types. Generally make it better https://pagure.io/389-ds-base/issue/49941 Author: William Brown <william@blackhats.net.au>
e59b309c -
Mark Reynolds authored
Description: Add replication functionality to the dsconf. This includes repl config, agmts, winsync agmts, and cleanallruv/abort cleanallruv Adjusted the backend options to use hyphens for consistency https://pagure.io/389-ds-base/issue/49926 Reviewed by: spichugi & firstyear(Thanks!!)
4881826e -
Viktor Ashirov authored
Description: nsAccount is not supported by 1.3.x branch. Fix description: Remove nsAccount objectClass from Replication Manager if DS is older than 1.4.x. https://pagure.io/389-ds-base/issue/49926 Reviewed by: mreynolds, firstyear (Thanks!)
fc2008c4 -
Simon Pichugin authored
Description: First commit that refactors Schema object and removes SchemaLegacy usage from CLI. Add full CLI Schema functionality to lib389. It includes: list, query, add, edit, remove operations. https://pagure.io/389-ds-base/issue/49928 Reviewed by: mreynolds, wibrown (Thanks!)
219fd4b1 -
Thierry Bordaz authored
Bug Description: The page size is retrieved from uint32_t dblayer_page_size. Later it is stored in a size_t variable with a cast. Depending on little/big endian the page size can be stored in the upper/lower bits of the 64bits variable. Later the variable is used to set the page size of a database file using the lower bits (uint32_t) that are zeroed. Fix Description: The BDB callback to set the pagesize, expects a a uint32_t. Make sure the field containing it is uint32_t (instead of size_t) as the page size is retrieved as a uint32_t as well (dblayer_page_size/BACK_INFO_INDEXPAGESIZE) https://pagure.io/389-ds-base/issue/49954 Reviewed by: Ludwig Krispen Platforms tested: F27 Flag Day: no Doc impact: no
b4164ccf -
Simon Pichugin authored
Description: Add schema functionality for add/edit/remove for for attributes and objectClasses. Add get_attr_syntaxes funciton. Fix small CLI schema issues and lib389 API part. Set LogCapture level on the init. Add copyright for cli/conf_backup_test.py. https://pagure.io/389-ds-base/issue/49928 Reviewed by: mreynolds, mhonek (Thanks!)
efa39cbc -
Thierry Bordaz authored
Bug Description: During an extended search, a structure is created for each filter component. The structure contains the keys generated from the assertion and using the given matching rule indexer. Later the keys will be compared (with the MR) with keys generated from the attribute values of the candidate entries. The bug is that parsing the assertion, instead of removing the heading spaces the routine clear the assertion that is empty. So the generated keys is NULL. Fix Description: The fix consists to only remove heading spaces https://pagure.io/389-ds-base/issue/49958 Reviewed by: Mark Reynolds Platforms tested: F27 Flag Day: no Doc impact: no
ff3da975 -
Matúš Honěk authored
Bugs and fixes description: - 15607: - in lib389/suffix.py: Structurally dead code - 15604: - in bug_harness.py: Null dereference + solved by removing the file as it is unused and outdated - additionally, remove the static_var decorator definition as it is not used anyway any more - 15754: - in pwdPolicy_syntax_test.py: fix typo in identifier + Fix log msg in file pw.c - 17046, 17061, 17063, 17069, 17084: - in backend_test and backendLegacy_test: fix use before NULL check - 17473: - in lib389/__init__.py: Identical code in different branches + removed the wrapper altogether as we don't support Python2 any more - replace SafeConfigParser with ConfigParser for it has been just an alias since Python 3.2 and will be removed in the future https://pagure.io/389-ds-base/issue/49947 Author: mhonek Review by: spichugi, firstyear (Thanks!)
4f118f42 -
Viktor Ashirov authored
Bug Description: When building with gcc, we need to link wit libasan. Fix Description: Add -lasan to compiler flags. https://pagure.io/389-ds-base/issue/49963 Reviewed by: tbordaz (Thanks!)
c73cd26d -
Thierry Bordaz authored
Ticket 49915 - Master ns-slapd had 100% CPU usage after starting replication and replication cannot finish Bug Description: During a total initialization the supplier builds a candidate list of the entries to send. Because of https://fedorahosted.org/389/ticket/48755, the candidate list relies on parentid attribute. All entries, except tombstones and suffix itself, have parentid. There is an assumption that the first found key (i.e. '=1') contains the suffix children. So when it finally finds the suffix key it adds its children to a leftover list rather to the candidate list. Later idl_new_range_fetch loops for ever trying to add suffix children from leftover to candidate list. Fix Description: The fix consist to store the suffix_id (if it does not exist already) in the parentid index (with the key '=0'). Then get it to detect the suffix key from the index in idl_new_range_fetch. https://pagure.io/389-ds-base/issue/49915 Reviewed by: Ludwig Krispenz, William Brown (thanks !) Platforms tested: F27 Flag Day: no Doc impact: no
bdb86769 -
Matúš Honěk authored
Bug Description: Test suites/filter/rfc3673_all_oper_attrs_test.py::test_search_basic does not reach constraints extensively. The asserts are too benevolent. The commit 6ef4eb5a changed 'normal user' ACIs, however these changes introduced new attr 'modifiersName' which was supposed to be missing when searching. In the first case, assert checks only for 'objectClass' and pseudo-randomly one more attr to be present which is not sufficient. In the second case, recently changed assert introduced weaker check than the one present before. Fix Description: Bring back previous ACI to explicitly test the difference when binding as normal user and the DM. In case of add_attr == '*', test for all expected_attrs to be in found_attrs. In the other case bring back the strict comparison as there used to be before. https://pagure.io/389-ds-base/issue/49943 Author: mhonek Review by: firstyear, spichugi (Thanks!)
e2810e78 -
Mark Reynolds authored
Bug Description: There are two issues here. The one in we don't cloase a connection when an invalid unbind occurs. The other is a search request passing 8MB of NULL bytes as search attributes will keep one thread busy for a long time. The reason is that the attr array is copied/normalized to the searchattrs in the search operation and does this using charray_add() which iterates thru the array to determine the size of the array and then allocate one element more. So this means we iterate 8 million times an array with a then average size of 4 million elements. Fix Description: We already have traversed the array once and know the size, so we can allocate the needed size once and only copy the element. In addition we check for the kind of degenerated attributes "" as used in this test scenario. So the fix will reject invalid attr lists and improve performance for valid ones Author: Ludwig Krispens <lkrispen@redhat.com> https://pagure.io/389-ds-base/issue/49969 Reviewed by: tbordaz & mreynolds (Thanks!)
a49bd03d -
Mark Reynolds authored068a00fb
-
Mark Reynolds authored
Description: Fix regression that casued a crash https://pagure.io/389-ds-base/issue/49969
a6369790 -
German Parente authored
Bug Description: when a replication agreement starts with "cn=->...", the upgrade is removing the entry. Fix Description: a check is missing when re-building dse.ldif in "setup-ds.pl -u" that provoked this entry not to be re-added to the file. https://pagure.io/389-ds-base/issue/49946 Author: German Parente <gparente@redhat.com> Review by: ???
614837ac -
Thierry Bordaz authored
Ticket 49968 - Confusing CRITICAL message: list_candidates - NULL idl was recieved from filter_candidates_ext Bug Description: When a filter component is indexed but returns an empty IDL an alarming message is logged although it is normal. Fix Description: Remove the alarming message https://pagure.io/389-ds-base/issue/49968 Reviewed by: Mark Reynolds Platforms tested: F27 + testcase Flag Day: no Doc impact: no
80d0d712 -
Mark Reynolds authoredd2aa131f