Skip to content

Review

Stephan Lachnit requested to merge stephanlachnit/pcmemtest:debian/suggestions into debian/master

Hi Felix,

I've given your packaging a quick review and here are my suggestions. Overall you did nothing wrong, these are just some eye candy.

For a8e0bbd3 see the comment in the commit, for fb63b032f92eb0241814de5cb4ee8c22155e0002 I suggest you take a look at the README from the Salsa CI team. You can find the CI run for the package here. I strongly recommend you to enable and use the CI for your packages, it more often than I would have wished revealed some stupid mistakes.

Once this is merged I can upload it if you don't want to change anything else. Thank you very much for packaging this, really cool to have this available just from grub!

Just two quick questions:

  1. Is there any particular reason you build the 32bit and 64bit image on all arches? Have you considered using something like this:
SOURCEDIRECTORY=build64

ifeq (,$(filter $(DEB_HOST_ARCH),i386))
	SOURCEDIRECTORY=build32
endif
  1. During installation I get a warning. Is this expected?
Warning: os-prober will not be executed to detect other bootable partitions.
Systems on them will not be added to the GRUB boot configuration.
Check GRUB_DISABLE_OS_PROBER documentation entry.

Merge request reports