Skip to content
Snippets Groups Projects
Verified Commit e24c95c0 authored by Maytham Alsudany's avatar Maytham Alsudany
Browse files

Skip publicsuffix tests TestPublicSuffix, TestSlowPublicSuffix, and TestNumICANNRules

These tests are hardcoded by upstream to check against parts of the test data,
but break when the test data is regenerated from the latest publicsuffix data,
which is constantly changing.

This patch skips TestPublicSuffix, TestSlowPublicSuffix, and
TestNumICANNRules, which are all affected by this problem and resulted in test
failures.

Closes: #1089192
parent 6ab3ef3b
No related branches found
No related tags found
1 merge request!1New upstream version 0.33.0
publicsuffix.patch
skip-publicsuffix-tests.patch
From: Maytham Alsudany <maytha8thedev@gmail.com>
Bug-Debian: https://bugs.debian.org/1089192
Forwarded: not-needed
Description: skip publicsuffix tests
These tests are hardcoded by upstream to check against parts of the test data,
but break when the test data is regenerated from the latest publicsuffix data,
which is constantly changing.
.
This patch skips TestPublicSuffix, TestSlowPublicSuffix, and
TestNumICANNRules, which are all affected by this problem and resulted in test
failures.
--- a/publicsuffix/list_test.go
+++ b/publicsuffix/list_test.go
@@ -295,6 +295,7 @@
}
func TestPublicSuffix(t *testing.T) {
+ t.SkipNow()
for _, tc := range publicSuffixTestCases {
gotPS, gotICANN := PublicSuffix(tc.domain)
if gotPS != tc.wantPS || gotICANN != tc.wantICANN {
@@ -304,6 +305,7 @@
}
func TestSlowPublicSuffix(t *testing.T) {
+ t.SkipNow()
for _, tc := range publicSuffixTestCases {
gotPS, gotICANN := slowPublicSuffix(tc.domain)
if gotPS != tc.wantPS || gotICANN != tc.wantICANN {
@@ -313,6 +315,7 @@
}
func TestNumICANNRules(t *testing.T) {
+ t.SkipNow()
if numICANNRules <= 0 {
t.Fatal("no ICANN rules")
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment