Skip to content

Use a different workaround for #988787

Simon McVittie requested to merge smcv/cdebconf:force-reasonable-size into master
  • Revert "gtk: Don't add text to GtkTextView until GTK has done initial layout"

    Deferring addition of the text to the GtkTextView means the initial window layout for select/multiselect questions will be done based on the assumption that there is no text, which means the GtkTreeView will receive nearly the full window height. When we scroll the GtkTreeView to bring the selected row into view, that also happens before the text is added.

    When the GtkTreeView is resized as a result of the text being added, the top left corner is preserved; if its selected row was near the bottom, the result is that the selected row is no longer visible.

    This reverts commit ba983d6b.

    Closes: #988951 Reopens: #988787

  • gtk: Make sure text views request a reasonable size

    Pango >= 1.44 sometimes behaves unexpectedly when asked to fit text into a space that is too small to be reasonable: when we give it the amount of space that it previously said was adequate, it will sometimes ask for more space. This leads to GTK 2 going into an infinite loop of redoing the layout (#988786) as the combination of GTK and Pango flaps between two size requests.

    It isn't clear whether this is a bug in GTK 2 or Pango or Debconf, but we can dodge it by making sure the size request is something more reasonable.

    Closes: #988787

/cc @kibi

Merge request reports

Loading