Skip to content

WIP: gtk: Hold the GDK lock while adding text in an idle

Simon McVittie requested to merge smcv/cdebconf:lock-while-adding-text into master

cdebconf-gtk uses the deprecated calling pattern where more than one thread calls into GTK, so we need to take the GDK lock before manipulating GTK widgets. Invoking a callback in the GUI thread doesn't guarantee that the GDK lock will be held.

This will become unnecessary if all the uses of GTK move into the GUI thread in a future release.

Not tested yet (at all), but I think this is pedantically necessary as a follow-up to !6 (merged). I'm opening the MR already to alert @kibi that we might want this before cdebconf migrates.

Merge request reports