Skip to content

Disable partition reuse when choosing recipes on entire disks

Pascal Hambourg requested to merge pham/partman-auto:choose_recipe-fixes into master

Partition reuse should be enabled only when partitioning in free space and disabled when partitioning entire disks. Else the minimum disk size for a recipe may be underestimated when the disk contains reusable partitions (efi, swap), resulting in allowing recipes which require more space than the disk size and when such recipe is used, in undersized partitions or failure to create all the partitions.

See https://lists.debian.org/debian-boot/2024/08/msg00151.html and https://lists.debian.org/debian-boot/2024/09/msg00094.html

Step 1: Add an optional "reuse" parameter to choose_recipe(). Call filter_reuse only when this parameter is not empty. Set this parameter in autopartition only if using free space.

Step 2: Add an optional "reuse" parameter to decode_recipe() and perform_recipe. Search reused partitions only when this parameter is not empty. Set this parameter in choose_recipe(), autopartition and perform_recipe only if using free space.

partman-lvm and partman-lvm-crypto can use only entire disks, so there is no need to update them.

(Marked as draft because roughly tested)

Merge request reports