trickle up error messages in JSON RPC calls

I had a misconfiguration in my KGB bot: the repository I was trying to talk to wasn't mapped properly in the kgb.conf file. Yet the error I was getting was the cryptic:

Server returned error: [TPA] Internal server error

"TPA" being the repo-id of course. This was utterly useless and made it really hard to diagnose. I ended up adding KGB->debug() statements all over the place to try to pinpoint where things were failing and finally figured out there was a die() in the relay_message routine. Yet we were not propagating that error message back up in any way (except maybe with KGB->out but that doesn't show up anywhere that I could see).

So this should make things a little easier to debug for users, now it shows:

Server returned error: [TPA] Internal server error: Repository TPA has no associated channels.

Merge request reports

Loading