Commits on Source (56)
-
Daniel P. Berrange authored
Signed-off-by:Daniel P. Berrange <berrange@redhat.com>
a15586fd -
Pino Toscano authored
libsoup is used to check the validity of URLs in distributions in osinfo-db; OTOH it supports only HTTP(S), so this limits the checks to that protocol. To overcome this limitation, switch to libcurl: while it requires slightly more code to do the same task, it provides a bit more flexibility, and support for other protocols. No version check is performed, since the APIs used are old enough. Adapt also the README, and the packaging files. Acked-by:Christophe Fergeau <cfergeau@redhat.com>
b61be040 -
Pino Toscano authored
Now that test-mediauris uses libcurl, it can handle protocols different than http(s), like ftp, just fine. This reverts commit 4c9c7185. Acked-by:
93c54a31 -
Pino Toscano authored
With the growing amount of distros in osinfo-db, the test takes more and more time to complete, hitting the 2 minutes timeout in case of any network hiccup (or simply when a server takes more time to reply). Hence, raise the timeout to 5 minutes, which ought to be enough now. Acked-by:8a19e519 -
Pierre-Alain TORET authored
Signed-off-by:
Pierre-Alain TORET <pierre-alain.toret@protonmail.com> Acked-by:
641ded14 -
Pierre-Alain TORET authored
Signed-off-by:
1b6c5f27 -
Pierre-Alain TORET authored
Signed-off-by:
593a20ae -
Pierre-Alain TORET authored
Signed-off-by:5a741552 -
Pino Toscano authored
Actually use the result of the configure switch --enable-tests, enabling or disabling the tests accordingly. Signed-off-by:
Pino Toscano <ptoscano@redhat.com> Reviewed-by:
206a5445 -
Pino Toscano authored
Look for curl only when the tests are enabled, and as optional build dependency. If curl is missing, then the two network tests are not built. Also, limit the use of curl CFLAGS/LIBS only for the tests that really need it. As side result, it is possible to drop the curl BuildRequires from the mingw spec, as it builds with --enable-tests=no. Signed-off-by:
cc5be3ae -
Pino Toscano authored
GLib has shipped a testing framework for many years already, so we can make use of it, replacing the external "check". The conversion only switches framework without changing the structure of the tests, making use of the more appropriate assertion in the various places. Signed-off-by:e51865eb -
Roman Bogorodskiy authored
Acked-by:0520470d -
Pavel Hrdina authored
This failed on FreeBSD with following error: ../../tests/test-mediauris.c:47:13: error: variable 'response_code' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] Reviewed-by:
Pavel Hrdina <phrdina@redhat.com>
f11a191c -
Pavel Hrdina authored
This failed on FreeBSD with following error: ../../tests/test-treeuris.c:47:13: error: variable 'response_code' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] Signed-off-by:25a4aa05 -
Debarshi Ray authored
Even though g_main_loop_new accepts a is_running parameter, it isn't very important since g_main_loop_run will set it to TRUE anyway. There is no requirement that it should be set before calling g_main_loop_run. The vast majority of GMainLoop users simply ignore the is_running parameter unless they are doing something out of the ordinary.
9955c547 -
Christophe Fergeau authored
These are currently missing from osinfo-db Signed-off-by:
75c19ba9 -
Zeeshan Ali authored
Use of 'const' parameter on object parameters is redundant, inconsistent (both internally and against other GObject libraries) and currently breaks the low-level Rust binding generator: https://github.com/gtk-rs/glib/pull/249 Signed-off-by:
Zeeshan Ali <zeeshan@kinvolk.io>
862b8c4b -
Pino Toscano authored
Signed-off-by:af47d32b -
Daniel P. Berrange authored
Signed-off-by:03f4b905 -
Christophe Fergeau authored
Since the switch to the GTest framework, when the test suite fails to identify an ISO, the error message is: ERROR:test-isodetect.c:359:test_one: 'matched' should be TRUE while it used to be the much more explicit: ERROR **: ISO alpine-extended-3.7.0_rc2-x86_64.iso.txt was not matched by OS alpinelinux3.7 This commit readds the explicit message on this particular failure. Signed-off-by:4ba5728d -
Felipe Borges authored7c3ad866
-
Felipe Borges authoredfd208b43
-
Christophe Fergeau authored
Based on a patch from Vicente Chaves de Melo <vchaves@ymail.com>
24440199 -
Christophe Fergeau authored
When adding support for a new vendor, test-isodetect.c needs to be updated to list it, which is too easy to forget. This commit iterates over subdirs in tests/isodata/ and uses these as the vendors to test for. This means no further modification of test-isodetect.c is needed when adding a new vendor. Signed-off-by:da9e4887 -
Daniel P. Berrangé authored
GCC 8 adds -Wfunction-cast-type to -Wextra, but this breaks when using G_DEFINE_TYPE which does so called "bad" function casts. Signed-off-by:6103f7fa -
All tests call that method because they want g_warning() to be fatal. Since the switch to GTest, this is no longer necessary as this is the default behaviour. Signed-off-by:
Fabiano Fidêncio <fabiano@fidencio.org>
ec4fb588 -
Reviewed-by:e6e33024 -
Reviewed-by:77d71d08 -
Add SLE12 SP3 ISO Information Signed-off-by:
Charles Arnold <carnold@suse.com> Reviewed-by:
03398308 -
Signed-off-by:
d3acf865 -
Reviewed-by:55504f7c -
Currently when loading DB files we process them in whatever order readdir() returns them in, which is often inode order. This makes the order of loading files non-deterministic across installs, and if there are ambiguities in the data, we can in turn get different results. eg ISO images match different OS entries depending on load order. Alphabetically sorting the files doesn't remove any ambiguity that may exist, but at least gives us consistent results on every host. Signed-off-by:
aa06a8b2 -
Vincent authored
Signed-off-by:Vincent <vincent.dao@asianux.com>
f0b54300 -
Natanael Copa authored
Signed-off-by:
Natanael Copa <ncopa@alpinelinux.org> Signed-off-by:
1a907776 -
Pierre-Alain TORET authored
Signed-off-by:ab3f78d8 -
Christophe Fergeau authored
'tmp' is used to iterate over the list of files, so it will be NULL at the end of the iteration, and g_list_free() will be a no-op. The initial list is stored in 'children', so free that instead. Signed-off-by:
f7d8a089 -
Fabiano Fidêncio authored
Signed-off-by:
fb26c24a -
Fabiano Fidêncio authored
Signed-off-by:
74dcc9b4 -
Fabiano Fidêncio authored
Signed-off-by:
3182ab0e -
Signed-off-by:
Felipe Borges <feborges@redhat.com> Reviewed-by:
917ade1c -
Andrea Bolognani authored
There is a spurious empty line at the end of the file that causes 'make syntax-check' to fail with: [...] tests/isodata/rhel/rhel7.5/RHEL-7.5-20180322.0-Server-ppc64le-dvd1.iso.txt maint.mk: empty line(s) or no newline at EOF make: *** [maint.mk:927: sc_prohibit_empty_lines_at_EOF] Error 1 Get rid of it to solve the issue. See also https://ci.centos.org/view/libvirt/job/libosinfo-master-syntax-check/123/ Reviewed-by:
Andrea Bolognani <abologna@redhat.com>
106d8690 -
Andrea Bolognani authored
The script was originally used by the Test::AutoBuild project to perform periodic automatic builds; however, that effort has been abandoned a long time ago, and these days libosinfo CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], where build recipes are maintained separately from the projects themselves. The script is still used to prepare releases, so it can't be dropped from the repository: rename it so that its purpose is more clearly communicated instead. [1] https://ci.centos.org/view/libvirt/ Reviewed-by:
fbfd66ba -
Andrea Bolognani authored
They are misleading, and no longer relevant anyway. Reviewed-by:
d829b942 -
Andrea Bolognani authored
It was mainly meant to be used for automatic builds through Test::AutoBuild, so it can be removed now. Reviewed-by:
25b5bc35 -
Daniel P. Berrangé authored
AM_CONDITIONAL lines must always be executed, but HAVE_CURL was inside an "if ...", which caused configure to fail when run on Win32. Signed-off-by:ca57ccbd -
Andrea Bolognani authored
The usual behavior is for configure to detect the availability of gtk-doc, along with other optional features, and only enable it if found. Hardcoding it this way is causing issues for MinGW builds, where pkg-config is looking in the MinGW-specific paths and can't locate the native gtk-doc.pc file, thus concluding gtk-doc must not be present and aborting the build altogether instead of simply skipping API reference generation. Both 'make distcheck' (through the DISTCHECK_CONFIGURE_FLAGS variable) and the prepare-release.sh script are already enforcing the availability of gtk-doc when preparing releases, so it's safe to use the default behavior for regular builds. Signed-off-by:5e25cf65 -
Clang 6 doesn't like the way the last item in a GOptionEntry array is initialized: ../../tools/osinfo-install-script.c:87:12: error: missing field 'short_name' initializer [-Werror,-Wmissing-field-initializers] { NULL } ^ 1 error generated. gmake[2]: *** [Makefile:540: osinfo-install-script.o] Error 1 gmake[2]: *** Waiting for unfinished jobs.... ../../tools/osinfo-detect.c:104:12: error: missing field 'short_name' initializer [-Werror,-Wmissing-field-initializers] { NULL } ^ 1 error generated. gmake[2]: *** [Makefile:540: osinfo-detect.o] Error 1 Fix the issue by using the { 0 } initializer instead. Signed-off-by:Eric Blake <eblake@redhat.com> Reviewed-by:
481c3a32 -
Signed-off-by:
fce35487 -
Fabiano Fidêncio authored
Signed-off-by:
e65cd1da -
Fabiano Fidêncio authored
test-os-resources has been written to avoid bug as having minimum resources greater than the recommended resources in osinfo-db. This problem was exposed by RHEL/CentOS data files, which caused some really bad UI effect in clientes using those two attributes (as GNOME Boxes). Signed-off-by:
6a88a781 -
Fabiano Fidêncio authored
Signed-off-by:
2f4ab3f4 -
Fabiano Fidêncio authored
When adding the symbols for LIBOSINFO_0.2.13 I mistakenly added the symbols not respecting default identation used (1 tab) and ended up using 4 spaces instead. Signed-off-by:
Michal Privoznik <mprivozn@redhat.com>
ba054e4e -
Fabiano Fidêncio authored
Reported-by:
cf827433 -
Fabiano Fidêncio authored
Signed-off-by:
545c695b -
Daniel P. Berrangé authored
Signed-off-by:24f879d6 -
Guido Günther authored91628ff3
