Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
L
libvirt
Manage
Activity
Members
Labels
Plan
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Libvirt Packaging Team
libvirt
Commits
1c9a023b
Commit
1c9a023b
authored
16 years ago
by
Guido Günther
Browse files
Options
Downloads
Patches
Plain Diff
libvirt_proxy: Fix use of uninitalized memory
We currently don't build this code (CVE-2009-0036).
parent
5c9dfd7d
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
debian/patches/0009-libvirt_proxy-Fix-use-of-uninitalized-memory.patch
+30
-0
30 additions, 0 deletions
...s/0009-libvirt_proxy-Fix-use-of-uninitalized-memory.patch
debian/patches/series
+1
-0
1 addition, 0 deletions
debian/patches/series
with
31 additions
and
0 deletions
debian/patches/0009-libvirt_proxy-Fix-use-of-uninitalized-memory.patch
0 → 100644
+
30
−
0
View file @
1c9a023b
From: Rasputin <rasputin@email.ru>
Date: Tue, 27 Jan 2009 21:33:12 +0300
Subject: [PATCH] libvirt_proxy: Fix use of uninitalized memory
On short read, members of packet header are checked before actually read.
If uninitialized values can pass the test, they can be set to arbitrary
values while reading remaining portion of a packet.
Buffer overflow is possible. libvirt_proxy is suid-root.
CVE-2009-0036
---
proxy/libvirt_proxy.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/proxy/libvirt_proxy.c b/proxy/libvirt_proxy.c
index 3b0dc42..8657f62 100644
--- a/proxy/libvirt_proxy.c
+++ b/proxy/libvirt_proxy.c
@@ -385,7 +385,8 @@
retry:
fprintf(stderr, "read %d bytes from client %d on socket %d\n",
ret, nr, pollInfos[nr].fd);
- if ((req->version != PROXY_PROTO_VERSION) ||
+ if ((ret != sizeof(virProxyPacket)) ||
+ (req->version != PROXY_PROTO_VERSION) ||
(req->len < sizeof(virProxyPacket)) ||
(req->len > sizeof(virProxyFullPacket)))
goto comm_error;
--
This diff is collapsed.
Click to expand it.
debian/patches/series
+
1
−
0
View file @
1c9a023b
...
...
@@ -6,3 +6,4 @@
0006-Fix-missing-read-only-access-checks-CVE-2008-5086.patch
0007-don-t-fail-on-missing-locales.patch
0008-Don-t-hardcode-ssh-port.patch
0009-libvirt_proxy-Fix-use-of-uninitalized-memory.patch
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment