Skip to content
Snippets Groups Projects
Commit a8fee3f3 authored by Guido Günther's avatar Guido Günther
Browse files

Don't validata filesystem target type.

Since 'virsh' validates XML this can lead to uneditable (but perfectly
valid) configs.
parent f5e46fbb
No related branches found
No related tags found
No related merge requests found
From: =?utf-8?q?Guido_G=C3=BCnther?= <agx@sigxcpu.org>
Date: Sat, 21 Mar 2015 11:37:12 +0100
Subject: Don't validata filesystem target type
When using QEMU's 9pfs the target "dir" element is not necessarily an
absolute path but merely an arbitrary identifier. So validation in that
case currently fails with the misleading
$ virt-xml-validate /tmp/test.xml
Relax-NG validity error : Extra element devices in interleave
/tmp/test.xml:24: element devices: Relax-NG validity error : Element domain failed to validate content
/tmp/test.xml fails to validate
---
docs/schemas/domaincommon.rng | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 1a266e5..e1cea6b 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -1929,9 +1929,7 @@
</choice>
<interleave>
<element name="target">
- <attribute name="dir">
- <ref name="absDirPath"/>
- </attribute>
+ <attribute name="dir"/>
<empty/>
</element>
<optional>
......@@ -27,3 +27,4 @@ upstream/vbox-fix-a-bug-in-_machineStateInactive.patch
security/CVE-2015-0236-qemu-Check-ACLs-when-dumping-security-.patch
security/CVE-2015-0236-qemu-Check-ACLs-when-dumping-securi-14.patch
qemu-Don-t-try-to-parse-help-for-new-QEM.patch
Don-t-validata-filesystem-target-type.patch
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment