Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
L
libvirt
Manage
Activity
Members
Labels
Plan
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Libvirt Packaging Team
libvirt
Commits
cb216b54
Commit
cb216b54
authored
8 years ago
by
Guido Günther
Browse files
Options
Downloads
Patches
Plain Diff
CVE-2017-2635: qemu: Don't update physical storage size of empty drives
parent
62ad2899
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
debian/patches/CVE-2017-2635-qemu-Don-t-update-physical-storage-size-of-.patch
+33
-0
33 additions, 0 deletions
...17-2635-qemu-Don-t-update-physical-storage-size-of-.patch
debian/patches/series
+1
-0
1 addition, 0 deletions
debian/patches/series
with
34 additions
and
0 deletions
debian/patches/CVE-2017-2635-qemu-Don-t-update-physical-storage-size-of-.patch
0 → 100644
+
33
−
0
View file @
cb216b54
From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 23 Feb 2017 10:07:30 +0100
Subject: CVE-2017-2635: qemu: Don't update physical storage size of empty
drives
Previously the code called virStorageSourceUpdateBlockPhysicalSize which
did not do anything on empty drives since it worked only on block
devices. After the refactor in c5f6151390 it's called for all devices
and thus attempts to deref the NULL path of empty drives.
Add a check that skips the update of the physical size if the storage
source is empty.
Upstream-Commit: c3de387380f6057ee0e46cd9f2f0a092e8070875
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1420718
---
src/qemu/qemu_driver.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index d4422f3..2bb5906 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -11644,6 +11644,9 @@
qemuDomainStorageUpdatePhysical(virQEMUDriverPtr driver,
int fd = -1;
struct stat sb;
+ if (virStorageSourceIsEmpty(src))
+ return 0;
+
if (qemuDomainStorageOpenStat(driver, cfg, vm, src, &fd, &sb) < 0)
return -1;
This diff is collapsed.
Click to expand it.
debian/patches/series
+
1
−
0
View file @
cb216b54
...
@@ -19,3 +19,4 @@ openpty-Skip-test-if-no-pty-is-available.patch
...
@@ -19,3 +19,4 @@ openpty-Skip-test-if-no-pty-is-available.patch
test-posix_openpt-don-t-fail-on-EACCESS.patch
test-posix_openpt-don-t-fail-on-EACCESS.patch
Disable-use-of-namespaces-by-default.patch
Disable-use-of-namespaces-by-default.patch
debian/Debianize-virtlogd.patch
debian/Debianize-virtlogd.patch
CVE-2017-2635-qemu-Don-t-update-physical-storage-size-of-.patch
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment