remove obsolete fdisk hack

8321653c (from 2007) introduced a hack to work around bug #445304 in gnu-fdisk for users who may have replaced fdisk with the classic gnu version. the hack allowed users to select an alternate fdisk binary to use to work around the buggy binary.

bug #445304 is marked as found in v1.0-1 and fixed in v1.2-1, though may have been fixe din v1.1. it was marked fixed in 2009.

checking the package archive, gnu-fdisk does not actually exist anymore in debian, with one exception - it is available for arm64 on sid via debports, and that version is 1.3 so thus includes the necessary fix anyway.

it is thus pointless now that we still carry this hack.

Gbp-Dch: Short

added 1 commit

• cf6e27d1 - remove obsolete fdisk hack

Compare with previous version

added 1 commit

• 2c9aa08c - remove obsolete fdisk hack

Compare with previous version

resolved all threads

added 1 commit

• d9f353c7 - remove obsolete fdisk hack

Compare with previous version

adjusted to check host instead of chroot for the fdisk package; it is only used from the host

Have you given this a test run?

yes, but not specifically with hdd type selected so it was only partially covered I expect, i'll try that now...

hmm, it might take a little while to get back to you, i ran a test targetting an HDD image and it seems to have died in the binary_grub-efi stage...

i've also just got dinner on and there are a few scheduled shows on TV starting shortly...

Sure, no rush

just incase you want to investigate whilst i'm busy... the grub efi failure is occurring from a clean run with config options of only -b hdd. it gets into the binary_grup-efi script and ends after issuing the following output:

P: UEFI Secure Boot support enabled.
W: Bootloader in this image type not yet supported by live-build.
W: This would produce a not bootable image, aborting (FIXME).

firstly that last item should be an error rather than a warning since we exit, secondly this should clearly not be happening and must be something going wrong with conditionally setting up the right defaults.

I've setup a rerun with -b hdd --bootloaders=syslinux to get back to the matter at hand, and i'll report back once that's done, i've eaten dinner and the TV progs are over :p

that completed without error

fyi the above mentioned unrelated problems have now been addressed in separate MRs

merged