Skip to content
Snippets Groups Projects

functions: drop unecessary perms

Closed Lyndon Brown requested to merge jnqnfe/live-build:func_perms into master

build stage scripts are executed thus need perms of 755; files that hold functions though are just included/imported into the executed scripts and thus have no purpose in being executable.

Gbp-Dch: Short

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • While this is true, it's also counter-productive because it generates many lintian warnings: W: live-build: script-not-executable usr/share/live/build/functions/sourcelist.sh

    We should drop the shebang at the same time if you follow your logic but the shebang helps with auto-detection of syntax-coloring in text editors so I prefer if we keep the current situation. Thus I'm closing this merge request.

  • Author Developer

    oh. i did not realise that such warnings would be generated. i certainly agree with closing this then. i would have tested it but intuitively it seemed so right and at the time i posted it it was very late and i was desperate for sleep. it was a last minute quick chown and push. :/

    i'd noticed late last night that debootstrap had 644 permissions and went off of that thinking that we should just do the same. debootstrap indeed does not have shebangs in those files though which must explain why they don't have any issue. i've actually tried to get them to change (debootstrap MR #42) for the purposes of correct auto-syntax highlighting which was going wrong in my editor, but they rejected it telling me that they don't care about changing code for one specific editor. :(

Please register or sign in to reply
Loading