Skip to content
Snippets Groups Projects

stagefile work part 3

Merged stagefile work part 3
jnqnfe/live-build:stagefiles3 into master
All threads resolved!
Merged Lyndon Brown requested to merge jnqnfe/live-build:stagefiles3 into master
All threads resolved!

the focus of this is to fix the completely broken Require_stagefile mechanism (as you'll understand from the commit message of the second commit (well, fifth with the part#2 stuff bundled)).

this obviously builds upon part #2 (robustification) in MR #117, which is still pending. i'll rebase once it's merged, but there's no reason to not let you see what's up next and no real reason that review cannot commence i guess.

testing a simple build worked fine, but i plan to next go through all of the files and double check the listed dependencies to be certain since up to now they've just been ignored. i'll push a fix if i spot anything.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Raphaël Hertzog
  • Lyndon Brown added 6 commits

    added 6 commits

    • dadeec9d - 1 commit from branch live-team:master
    • 1b09b152 - stagefiles: refactor Require_stagefile()
    • ea0f6b78 - stagefiles: fix completely wrong require-stages logic
    • 3bed138f - stagefiles: avoid stagename in required error
    • fe0d2358 - stagefiles: only list missing stages
    • fb0790cc - stagefiles: s/Require_stagefile/Require_stagefiles/

    Compare with previous version

    Toggle commit list
  • Lyndon Brown
    Lyndon Brown @jnqnfe ·
    Author Developer

    update: i did go through the set of dependencies today, as I said I would in the original description. I found no issues that would cause a problem with the change in behaviour of the function, complementing the successful test run.

    Edited by Lyndon Brown
  • Raphaël Hertzog added 1 commit

    added 1 commit

    • bdffaebe - Minor cleanups in Require_stagefiles

    Compare with previous version

  • Raphaël Hertzog resolved all threads

    resolved all threads

  • Raphaël Hertzog enabled an automatic merge when the pipeline for bdffaebe succeeds

    enabled an automatic merge when the pipeline for bdffaebe succeeds

  • Raphaël Hertzog merged

    merged

    • Please register or sign in to reply