Skip to content

grub2/loopback: extract more menu generation out to pre-prepared files, like syslinux

Lyndon Brown requested to merge jnqnfe/live-build:bootloader-improvements-3d into master

This allows:

  • Simplification of the code somewhat, because less of the menu is being constructed in the code.
  • Derivative dists (or users) to customise the menus more easily.

Overview:

  • install menus simply moved to menu files
  • dynamic choice between using gui+text or text-only based installer menus by picking between the two files, like syslinux
  • memtest similarly moved out, with a placeholder to be replaced with true|false to control appearance (more simple that trying to entirely control inclusion/exclusion of the menu code for it entirely like syslinux whilst still moving it out)
  • similar placeholder introduced to control appearance of installer menu
  • replacement of LINUX_LIVE placeholder with @LINUX_LIVE@ for consistency and clarity
  • changed to writing live menu entries to a temporary file, and then using sed to inject the file content in place of the placeholder, rather than building up a big string, and avoiding all of the other sed placeholder replacement stuff
  • we avoid having to make calls to perl! :shudder:
Edited by Lyndon Brown

Merge request reports