Skip to content
Snippets Groups Projects

Print an error and exit if a host package (dependency) is missing even with chroot build, fix binary_onie dependencies and add Suggests

Merged Luca Boccassi requested to merge bluca/live-build:onie_suggests into master

@hertzog I hope it's OK to add the suggests, it follow the same model as other scripts (eg: parted).

I found out the hard way that the script won't error out if there's a missing (host) dependency and it's doing a chroot build, so I'd propose this change to make it error out with a clear message. Do you see any drawbacks?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I don't see any drawback.

    I would put the missing dependencies in Recommends instead of Suggests as they are needed for the onie script to work (even if the target is optional). cpio and apt-utils are other "host dependencies" and they are in Recommends after all.

    It's not like those are big dependencies so we are not imposing any significant extra cost. "coreutils" is "Essential: yes" so should probably be dropped however.

    Feel free to merge your changes after having taken into account my remarks.

  • Luca Boccassi added 3 commits

    added 3 commits

    • a0335ac4 - ONIE: add Recommends for programs needed by binary_onie
    • 050e637b - ONIE: do not use package cache, only runs on host
    • 08dd0b90 - Print an error and exit if a host package (dependency) is missing.

    Compare with previous version

  • merged

  • Author Maintainer

    ACK, thanks!

Please register or sign in to reply
Loading