locks: tidy lock acquisition
Combine the check+create done in each script. (The original functions
are still callable as before, but a new combined Aquire_lockfile
function can be called instead, as now used).
Note, a further simplification could be done in removing the passing of the lock filename in as a parameter since every use of the functions is with ".lock". The lock functions already have a fallback to ".build/lock" though. Checking the history, the fallback used to be for a system wide lock, which was then replaced with this config-tree specific one. As long as that is not used implicitly by 3rd-party hooks then surely we are free to change the fallback to ".lock" and further remove passing in a name as a param...?
Gbp-Dch: Short Closes: #952918
Merge request reports
Activity
added 5 commits
-
f0e077ec...e3da1b6f - 4 commits from branch
live-team:master
- b8179c39 - locks: tidy lock acquisition
-
f0e077ec...e3da1b6f - 4 commits from branch
added 4 commits
-
b8179c39...f1647f0d - 3 commits from branch
live-team:master
- c865d4d4 - locks: tidy lock acquisition
-
b8179c39...f1647f0d - 3 commits from branch
added 11 commits
-
c865d4d4...2d9ab1f7 - 10 commits from branch
live-team:master
- 8d7c274b - locks: tidy lock acquisition
-
c865d4d4...2d9ab1f7 - 10 commits from branch
added 2 commits
just fyi, the note about further possible simplification was not intended to delay the change as implemented, if that's causing a hold up. it was more just intended to document a potential further improvement for the future.
though if review finds that indeed such a further improvement would be fine, then i could update as such now. (though i'd think it best to be done in a second commit anyway).
added 6 commits
-
b675d03b...10999bbd - 5 commits from branch
live-team:master
- 5d4f4598 - locks: tidy lock acquisition
-
b675d03b...10999bbd - 5 commits from branch
added 2 commits
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
added 6 commits
-
d0c670b2...67930f3e - 5 commits from branch
live-team:master
- 1c462c4b - locks: tidy lock acquisition
-
d0c670b2...67930f3e - 5 commits from branch
added 5 commits
-
1c462c4b...346e3e1c - 4 commits from branch
live-team:master
- b2792772 - locks: tidy lock acquisition
-
1c462c4b...346e3e1c - 4 commits from branch