Skip to content
Snippets Groups Projects

locks: tidy lock acquisition

Merged Lyndon Brown requested to merge jnqnfe/live-build:tidy_locks into master
All threads resolved!

Combine the check+create done in each script. (The original functions are still callable as before, but a new combined Aquire_lockfile function can be called instead, as now used).

Note, a further simplification could be done in removing the passing of the lock filename in as a parameter since every use of the functions is with ".lock". The lock functions already have a fallback to ".build/lock" though. Checking the history, the fallback used to be for a system wide lock, which was then replaced with this config-tree specific one. As long as that is not used implicitly by 3rd-party hooks then surely we are free to change the fallback to ".lock" and further remove passing in a name as a param...?

history: db5d2b0d 0aa8289a

Gbp-Dch: Short Closes: #952918

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lyndon Brown resolved all threads

    resolved all threads

  • Lyndon Brown added 6 commits

    added 6 commits

    Compare with previous version

  • Author Developer

    ok, all resolved, updated code pushed :thumbsup:

  • Lyndon Brown added 5 commits

    added 5 commits

    Compare with previous version

  • Please register or sign in to reply
    Loading