Skip to content
Snippets Groups Projects
Commit 938757a8 authored by Otto Kekäläinen's avatar Otto Kekäläinen
Browse files

Standardize on using capitalized 'ON' in CMake build options

- Standard CMake terminology is OFF/ON
  https://cmake.org/cmake/help/latest/command/option.html

- Always use capitalized string (e.g. 'YES' is better than 'yes')

- Always use 'ON' to enable something (not 'YES')

  (e.g. WITH_INNODB_SNAPPY only works with 'ON', does not recognize 'YES')

  Search for 'STREQUAL "ON"' yields 14 matches in project while search for
  'STREQUAL "YES"' yields results only for WITH_JEMALLOC, WITH_SSL,
  WITH_SYSTEMD and misc cases in WolfSSL and Mroonga, which is clearly
  less than 14 different plugins.

- Upstream cmake/plugin.cmake specifically checks for NO|YES to keep those
  strings for plugins.
parent 6c4c98d1
No related branches found
No related tags found
1 merge request!22Salsa-CI: Re-enable upgrade tests for Buster to Sid
......@@ -62,7 +62,7 @@ endif
# Only attempt to build with PMEM on archs that have package libpmem-dev available
# See https://packages.debian.org/search?searchon=names&keywords=libpmem-dev
ifneq (,$(filter $(DEB_HOST_ARCH),amd64 arm64 ppc64el riscv64))
CMAKEFLAGS += -DWITH_PMEM=yes
CMAKEFLAGS += -DWITH_PMEM=ON
endif
# Add support for verbose builds
......@@ -106,9 +106,9 @@ endif
-DCONC_DEFAULT_CHARSET=utf8mb4 \
-DPLUGIN_AWS_KEY_MANAGEMENT=NO \
-DPLUGIN_COLUMNSTORE=NO \
-DWITH_NUMA=auto \
-DIGNORE_AIO_CHECK=YES \
-DWITH_URING=YES \
-DWITH_NUMA=AUTO \
-DIGNORE_AIO_CHECK=ON \
-DWITH_URING=ON \
-DWITH_INNODB_SNAPPY=ON \
-DDEB=$(DEB_VENDOR)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment