Standardize on using capitalized 'ON' in CMake build options
- Standard CMake terminology is OFF/ON https://cmake.org/cmake/help/latest/command/option.html - Always use capitalized string (e.g. 'YES' is better than 'yes') - Always use 'ON' to enable something (not 'YES') (e.g. WITH_INNODB_SNAPPY only works with 'ON', does not recognize 'YES') Search for 'STREQUAL "ON"' yields 14 matches in project while search for 'STREQUAL "YES"' yields results only for WITH_JEMALLOC, WITH_SSL, WITH_SYSTEMD and misc cases in WolfSSL and Mroonga, which is clearly less than 14 different plugins. - Upstream cmake/plugin.cmake specifically checks for NO|YES to keep those strings for plugins.
parent
6c4c98d1
No related branches found
No related tags found
-
mentioned in commit otto/mariadb-server@a00656e4
-
mentioned in commit otto/mariadb-server@ebd2a911
-
mentioned in commit otto/mariadb-server@c5aa66c4
-
mentioned in commit otto/mariadb-server@03c40cd7
-
mentioned in commit otto/mariadb-server@5c469fd0
-
mentioned in commit otto/mariadb-server@39a85cbd
-
mentioned in commit otto/mariadb-server@fff9d32a
-
mentioned in commit otto/mariadb-server@bd69aceb
-
mentioned in commit otto/mariadb-server@fe9f95b5
-
mentioned in commit otto/mariadb-server@d4129510
-
mentioned in commit otto/mariadb-server@5c9bb25e
-
mentioned in commit otto/mariadb-server@b9867ad0
-
mentioned in commit 2a576322
Please register or sign in to comment