Skip to content
Snippets Groups Projects
Commit dcbcb9ae authored by Simon Tatham's avatar Simon Tatham
Browse files

Fix bug with restoring file position on [Q]/[RET].

I noticed recently that if I did this ...

 - examine a user and press [P][O] (or [P][T]) to see their posts
 - file position appears at the top of the feed, with an extension indicator
 - press [0] to extend, then [0] again to go to the top
 - pick a post in view and look at its thread
 - press [Q] to pop the activity stack back to the rest of the user's posts

... then the file position in the user's posts feed was not restored
to where it had been before I went to look at a thread. This turned
out to be because of the call to state.show_new_content() in
ensure_activity_state(), which was resetting the position to the
latest _read_ thing, not the place we had had the focus before.

That call was intended to update the position if you were 'moved' into
an interrupting feed like your mentions, from the same feed, so that
it would update to show the new thing. So it only really needs to
trigger in the case where 'is_interrupt' is set. Now it does.
parent 37bab54f
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment