Skip to content
Snippets Groups Projects

Stop calling client.fq() on URLs!

Merged Simon Tatham requested to merge fq into main

I think this must have been a copy-paste error from another field. When we're printing the URL of a toot or a user in the Mastodon web UI, we don't want to call client.fq() on it, which is the method that appends @domain to bare usernames.

I'm impressed at how long it's taken me to notice this bug! I think what must have happened is that nearly all Mastodon web UI URLs contain an @ sign (usually [site]/@user or [site]/@user/[more details]), which caused client.fq() to leave the string unchanged. But today I encountered an instance which formats its URLs differently, and finally noticed this glaring error.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading