Skip to content

Override makemessages command

Baptiste Beauplat requested to merge lyknode/debexpo:feat/makemessages-defaults into live

Override makemessages to:

  • Always build gettext files from the same location
  • Always keep the templates files
  • Use the file location type
  • Avoid updating headers of files without translation updates

I have to admit, I'm not quite satisfied with this MR, two things bugs me:

  • The copy/paste of the method from django code
  • The code to compare the files, header excluded. I can't quite put my finger on why it is bothering me but it kind of is.

I didn't add test coverage for that command (as for the other one). However, I did test it manually with translation updates and without.

Also note that I made a specific django app for the command because it has to be inside a app loaded before django and I didn't want to load debexpo before django.

Hoping a new set of eye on the code will help find better solution. Let me know what you think of it.

Closes: #152 (closed).

Merge request reports