Skip to content
Snippets Groups Projects
Commit 2f8217c2 authored by Damyan Ivanov's avatar Damyan Ivanov
Browse files

Avoid warning in Email::Sender::Transport::SMTP when parsing the version of Net::SMTP

Closes: #847219
parent d099f9e0
No related branches found
No related tags found
No related merge requests found
Description: use version->parse for parsing NET::SMTP's version
The current version of Net::SMTP in Debian is 3.08_01, which causes a warning
in Email::Sender::Transport::SMTP:
.
Argument "3.08_01" isn't numeric in numeric lt (<) at
/usr/share/perl5/Email/Sender/Transport/SMTP.pm line 266.
Bug-Debian: https://bugs.debian.org/847219
Author: Damyan Ivanov <dmn@debian.org>
Forwarded: https://github.com/rjbs/Email-Sender/issues/46
Bug: https://github.com/rjbs/Email-Sender/issues/46
--- a/lib/Email/Sender/Transport/SMTP.pm
+++ b/lib/Email/Sender/Transport/SMTP.pm
@@ -11,6 +11,7 @@ use MooX::Types::MooseLike::Base qw(Bool
use Net::SMTP 3.07; # SSL support, fixed datasend
use utf8 (); # See below. -- rjbs, 2015-05-14
+use version ();
#pod =head1 DESCRIPTION
#pod
@@ -263,7 +264,8 @@ sub send_email {
# the mock from ->new. We don't want to create a new SMTP just to get the
# version, and we can't rely on $smtp being a Net::SMTP object.
# -- rjbs, 2015-08-10
- utf8::downgrade($next_hunk) if (Net::SMTP->VERSION || 0) < 3.07;
+ utf8::downgrade($next_hunk)
+ if version->parse( Net::SMTP->VERSION || 0 ) < 3.07;
$smtp->datasend($next_hunk) or $FAULT->("error at during DATA");
}
net-smtp-version-cmp.patch
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment