Skip to content
Snippets Groups Projects
  1. Feb 02, 2025
  2. Dec 09, 2024
  3. Dec 06, 2024
  4. Dec 05, 2024
  5. Dec 04, 2024
  6. Dec 03, 2024
  7. Nov 28, 2024
  8. Nov 27, 2024
    • tgreenx's avatar
      Merge pull request #1397 from tgreenx/fix-edns · 760f9ea9
      tgreenx authored
      Fix default settings of queries
    • [Thomas Green]'s avatar
      Update unit test data · 4ef92767
      [Thomas Green] authored
      4ef92767
    • [Thomas Green]'s avatar
      Fix conflict on unit test data · 50287a18
      [Thomas Green] authored
      50287a18
    • [Thomas Green]'s avatar
      e116d4d9
    • [Thomas Green]'s avatar
      Update after review · f8f826d0
      [Thomas Green] authored
      Renamed some constants:
       - UDP_DNSSEC_QUERY_DEFAULT to EDNS_UDP_PAYLOAD_DNSSEC_DEFAULT
       - UDP_EDNS_QUERY_DEFAULT to EDNS_UDP_PAYLOAD_DEFAULT
       - UDP_EDNS_COMMON_LIMIT to EDNS_UDP_PAYLOAD_COMMON_LIMIT
      f8f826d0
    • [Thomas Green]'s avatar
      Update unit tests and unit tests data · a2d6e64f
      [Thomas Green] authored
      Use a different query name for each query as to make sure that we do not get a cached response from previous, equivalent queries.
      This is needed because the tested object is actually the underlying object in the "dns" attribute of the Zonemaster::Engine::Nameserver class,
      which is only updated by the "_query()" method, and not the "query()" method.
      a2d6e64f
    • [Thomas Green]'s avatar
      Update unit tests · 80a42615
      [Thomas Green] authored
      80a42615
    • [Thomas Green]'s avatar
      Add minimum value check for edns_size parameter in Zonemaster::Engine::Nameserver->query() · c9bcc372
      [Thomas Green] authored
      This parameter, set either by "edns_size" or "edns_details->size", is an unsigned 16-bit value,
      thus the minimum value should be 0. Documentation and unit tests are updated too.
      c9bcc372
    • [Thomas Green]'s avatar
      Add maximum value check for edns_size parameter in Zonemaster::Engine::Nameserver->query() · d9cf0e7c
      [Thomas Green] authored
      The maximum value for this parameter, set either by "edns_size" or "edns_details->size", is a 16-bit value,
      thus it should not exceed 65535. Documentation and unit tests are updated too.
      d9cf0e7c
    • [Thomas Green]'s avatar
      Fix default settings of queries · 92080b19
      [Thomas Green] authored
      Due to an oversight in a previous refactoring, all non-DNSSEC DNS queries sent by Zonemaster became
      EDNS queries. This commit makes it so that those queries are now non-EDNS queries. Default EDNS0 packet
      size values will now be properly used when appropriate, and a new, missing one has been created for DNSSEC.
      The caching logic of queries was also impacted.
      
      Simply put, a DNSSEC query using the default EDNS0 packet size of 1232 is made by setting parameter "dnssec"
      and/or "edns_details{do}" (the latter has precedence).
      For a non-DNSSEC EDNS query, setting parameter "edns_size" and/or "edns_details{size}" (the latter has precedence)
      will do the trick, but then it will use the provided value for the EDNS0 packet size. To use the default value of 512,
      just set parameter "edns_details" with an empty hash (or non-empty with any of its subkey(s) other than edns_details{do,size})
      instead.
      
      - Fix logic related to flags dnssec and edns_size for when to use default values, and also when combined with edns_details
      - Fix caching logic when using dnssec and edns_size parameters
      - Make combined usage of dnssec with edns_details but without edns_details{do} to correctly set the dnssec (DO) flag
      - Removed uneeded code related to resetting flags between queries (- it was already done earlier in the same method)
      - Add constant UDP_DNSSEC_QUERY_DEFAULT (set to 1232)
      - Rename constant UDP_COMMON_EDNS_LIMIT to UDP_EDNS_COMMON_LIMIT
      - Add and update documentation
      - Add unit tests
      92080b19
    • tgreenx's avatar
      Merge pull request #1396 from tgreenx/update-dnssec10 · d512d53a
      tgreenx authored
      Update DNSSEC10 implementation
    • Mats Dufberg's avatar
      Merge pull request #1395 from matsduf/new-unittests-delegation01 · 67959eac
      Mats Dufberg authored
      New unit tests for Delegation01, -02 and -03, and legacy tests are removed
  9. Nov 26, 2024
Loading