New feature: allow protocol selection using DPT_GITHUB_PROTOCOL

Using the environment variable DPT_GITHUB_PROTOCOL={https,ssh} one can choose between these two protocols to be used by git clone. Until now there was only support for ssh, but the module already requires a token for the API, so having the option to use https can be useful (it is to me).

This looks good to me, thank you. Maybe @alexm can have a look at the MR too …

added 1 commit

• daa047e4 - Improve documentation adding explicitly which protocols are accepted

Compare with previous version

resolved all threads

Is the OAuth token really needed to clone through https? In case it is, you should probably pass it as the password, not the username of the URL, i.e. https://{github-user}:{oauth-token}/{org-name}/{repo}.git

But I'm pretty sure that you don't have to pass the token to clone a public repo.

OTOH, why the need variable ends with word PROTOCOL but the param is named proto? Shouldn't both be named accordingly? I mean it's either proto or protocol in both cases.

added 2 commits

• 2f623c5c - Rename the parameter "proto" to "protocol"
• 07e31afd - Add username in https url

Compare with previous version

resolved all threads

added 1 commit

• 3e956f0b - Fix spacing and rename "user" to "login" and "owner" to "user"

Compare with previous version

resolved all threads

merged

mentioned in commit 4bd261f4