Vagrant Cascadian authored 2 years ago and Philip Hands committed 2 years ago

Bug#1018802: localechooser: reproducible builds: locale and parallelism trigger reproducibility issues

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Source: localechooser
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: locale randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The templates file contains randomness and locale-specific translations
dependent on the host system locale.

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffos=
cope-results/localechooser.html

  Indices-lo.UTF-8:=C2=B71,=C2=B72,=C2=B73,=C2=B74,=C2=B75,=C2=B76,=C2=B77,=
=C2=B78,=C2=B79,=C2=B710,=C2=B711, ... ,=C2=B750,=C2=B751
  vs.
  Indices-lo.UTF-8:=C2=B71,=C2=B73,=C2=B74,=C2=B75,=C2=B76,=C2=B77,=C2=B78,=
=C2=B79,=C2=B710,=C2=B711, ... =C2=B750,=C2=B751,=C2=B72,=C2=B719

  Choices-lo.UTF-8:=C2=B7Algeria,=C2=B7Angola,=C2=B7Benin,=C2=B7Botswana, .=
.. Eswatini,=C2=B7Ethiopia,=C2=B7Gabon ...
  vs.
  Choices-lo.UTF-8:=C2=B7Algeria,=C2=B7=E0=BA=9B=E0=BA=B0=E0=BB=80=E0=BA=97=
=E0=BA=94=E0=BA=AD=E0=BA=B1=E0=BA=87=E0=BB=82=E0=BA=81=E0=BA=A5=E0=BA=B2,=
=C2=B7Benin,=C2=B7Botswana, ... Eswatini,=C2=B7=E0=BB=80=E0=BA=AD=E0=BA=97=
=E0=BA=B4=E0=BB=82=E0=BA=AD=E0=BB=80=E0=BA=9B=E0=BA=8D,=C2=B7Gabon ...

That attached patches fix this by passing --no-parallel to dh (parallism
was probably introduced in the switch from debhelper compat 9 to 13),
and by exporting LC_ALL=3DC.UTF-8 in debian/rules.

Thanks for maintaining localechooser!

live well,
  vagrant

From 29d0987352263aa2ebedf89c558ff2868dd777d4 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 31 Aug 2022 01:04:15 +0000
Subject: [PATCH 1/2] debian/rules: Disable parallelism for reproducible build.

  * post-base-installer.d/05localechooser

[dgit --overwrite]

really detect the language level (closes: 1011254)

See merge request installer-team/localechooser!6

The previous code was cutting (-f 2-3) the language field off, before
grepping for the language, so the grep never found anything, and the
level was never 3 or 4.

  * Team upload

  [ Updated translations ]
  * Dutch (nl.po) by Frans Spiesschaert
  * Simplified Chinese (zh_CN.po) by Wenbin Lv

  [ Debian Janitor ]
  * Add missing ${misc:Depends} to Depends for localechooser.
  * Use set -e rather than passing -e on the shebang-line.
  * Bump debhelper from deprecated 9 to 13.
  * Set debhelper-compat version in Build-Depends.
  * Build-Depends: Drop versioned constraint on dpkg-dev and intltool-debian.
  * Drop versioned constraint on cdebconf-udeb in Depends.

[dgit import package localechooser 2.95]

Remove unnecessary constraints

See merge request installer-team/localechooser!5

* Build-Depends: Drop versioned constraint on dpkg-dev and intltool-debian.
* localechooser: Drop versioned constraint on cdebconf-udeb in Depends.

Changes-By: deb-scrub-obsolete

Fix some issues reported by lintian

See merge request installer-team/localechooser!4

Changes-By: lintian-brush
Fixes: lintian: uses-debhelper-compat-file
See-also: https://lintian.debian.org/tags/uses-debhelper-compat-file.html

Changes-By: lintian-brush
Fixes: lintian: package-uses-deprecated-debhelper-compat-version
See-also: https://lintian.debian.org/tags/package-uses-deprecated-debhelper-compat-version.html

Changes-By: lintian-brush
Fixes: lintian: maintainer-script-without-set-e
See-also: https://lintian.debian.org/tags/maintainer-script-without-set-e.html

Changes-By: lintian-brush
Fixes: lintian: debhelper-but-no-misc-depends
See-also: https://lintian.debian.org/tags/debhelper-but-no-misc-depends.html