Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P php
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 4
    • Merge requests 4
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • Debian PHP Team
  • php
  • Merge requests
  • !12

Fix detection of unknown gcc function attributes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Athos Ribeiro requested to merge athos/php:fix-gcc-func-attr into debian/main/8.1 May 03, 2022
  • Overview 4
  • Commits 1
  • Changes 2
  • LP: #1882279
  • https://github.com/php/php-src/pull/8483

As discussed in [1], and old, buggy gcc macro have been hindering the php build configuration step, resulting in a binary which cannot make use of some performance improvements introduced to php upstream.

The observe performance difference between the upstream binaries shipped in docker.io/php showed these upstream binaries may perform some operations up to 10x faster than the downstream versions in x86_64-v{2,3,4} machines.

The patch proposed here fixes the embedded gcc macro so the binary can be built leveraging the gcc function attributes that provide such performance boosts.

[1] https://bugs.launchpad.net/ubuntu/+source/php8.1/+bug/1882279/comments/9

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-gcc-func-attr