Skip to content

lintian: Fix 'incorrect-packaging-filename' warning for d/NEWS

Andreas Dolp requested to merge ecite/pkg-suricata:ad/make-pipelines-green into master

Background

  • Fix bugs to make salsa pipelines green
  • This also fixes a lot of lintian warnings

Description of changes

See the commit message per each commit for more details about why this change is done.

  • lintian: Fix 'incorrect-packaging-filename' warning for d/NEWS
    • Test: used current unstable amd64 machine with apt-listchanges installed: Upgrade from stable 7.0.10-1 to this new package (8.0.1-4~exp1+salsaci+20251021+34): Debian-News are displayed correctly
  • d/copyright: Remove superfluous file patterns for some deleted files
    • Files/folders do not exist any more
    • No tests required
  • lintian: Remove lintian override 'executable-in-usr-lib'
    • The lintian warning 'mismatched-override' means, that the actual override 'executable-in-usr-lib' for usr/lib/suricata/ebpf/*.bpf is not needed anymore, as no lintian warning about 'executable-in-usr-lib' is even produced.
    • This is probably due to changes in lintian itself, as the *.bpf files are still executables.
    • Finally speaking, this override can simply be removed.
    • No tests required: Lintian warning is gone now.
  • lintian: Fix file permissions of python/suricata/config/defaults.py
    • The install command, by default, sets 0755 if -m is not specified [1], so the file python/suricata/config/defaults.py will be marked as an executable, though it isn't. This causes a lintian warning, because this non-executable file should not be installed with executable permissions.
    • The attached patch fixes this by setting 0644 to this file.
    • If the MR gets merged, I can redirect the patch to upstream.
    • No tests done, as the file should not be executed itself. Reading with suricata-update should be possible anyway, but not tested.
  • blhc: Set ignore pattern for rust to avoid false-positives
    • According to the blhc manpage, only gcc is supported. [2]
    • Tried to build the rust code with --verbose, but this doesn't improve anything, so I think this warning can be disabled to make the salsa pipeline green.
    • This change simply prints a text line during build, which can be used by blhc to apply the regex to suppress the blhc warnings for rust comiling messages.
    • This is not a fix, just a suppress!
    • No tests done, except the suppressing seems to work and makes blhc pipeline job green
  • Fix non-existent '.ft C' in manpages to avoid lintian warnings
    • See commit message for details
    • Test: Opened all manpages and rendering (especially of the code parts) seems to be correct and looks fine.

Dependencies

  • None

Documentation

  • Not required

Tests

  • See changes section above

Links

Edited by Andreas Dolp

Merge request reports