Skip to content
Snippets Groups Projects

Update debian to requests version 2.28.1

Merged Lena Voytek requested to merge lvoytek/requests:debian/master into debian/master

Updated the debian branch with 2.28.0 and 2.28.1, refreshed the Remove-remote-images-traking-code-and-ads patch, and disabled test_json_decode_persists_doc_attr due to a ProxyError ([Errno 111] Connection refused) when building on Salsa

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi @lvoytek many thanks for your merge request! I was going to work on requests soon and I really thank you for making the big part of the work.

    Did you manage to test the packaging? Unfortunately I did setup the CI to work only on the master branch to not waste resources.

    I'm going to review it right now.

  • Author Maintainer

    Hi @eriol, thanks for reviewing so quickly! The package is working properly on its own, looking into reverse-dependencies now though

  • @lvoytek many thanks, already built the package to perform some check. Do you want to close https://bugs.launchpad.net/ubuntu/+source/requests/+bug/1993439 with the upload or do you prefer to close later on your own? You can close it changing the first line of d/changelog the following:

      * New upstream versions 2.28.0+dfsg and 2.28.1+dfsg (LP: #1993439).

    Also just one thing, since we are uploading just 2.28.1 (thanks for packaging 2.28.0 also, but it will not be in the archive, I mean I will upload just the latest version) so in debian/changelog we can avoid to mention 2.28.0. Could you change that line in

      * New upstream version 2.28.1+dfsg.

    Or

      * New upstream version 2.28.1+dfsg (LP: #1993439).

    if you want to close the launchpad bug within the upload.

    Thanks

    P.S. I can do it after the merge if you don't have the time. Just tell me what do you prefer.

  • Author Maintainer

    Thanks for the review! I'll close the lp bug later once its merged into Ubuntu. I'll update the changelog line change now to make things easier

  • Lena Voytek added 1 commit

    added 1 commit

    Compare with previous version

  • Just noticed that the CI started so I was not remembering how I configured it! :face_palm: Well in this case the outcome is fine.

  • @lvoytek thanks for updating d/changelog, I'm going to perform the latest check and then I will proceed with the upload. Thanks for taking care of requests.

    Edited by Daniele Tricoli
  • Daniele Tricoli mentioned in commit 2f7cf1ca

    mentioned in commit 2f7cf1ca

Please register or sign in to reply
Loading