Skip to content
Snippets Groups Projects

Remove *.egg-info directories in clean step

Merged Stuart Prescott requested to merge stuart/dh-python:tmp/clean-eggs into master
1 unresolved thread

Removing the egg-info directory automatically in the 'clean' step means that if the build changes the egg-info, the change will not trip up the next build of the source package.

  • if the egg-info directory is generated by the build, then removing it is the right thing to do

  • if the egg-info directory is included in the upstream source, then deleting it causes no harm as dpkg-source warns on missing files in the source package but does not exit with error.

Merge request reports

Checking pipeline status.

Merged by Stefano RiveraStefano Rivera 1 year ago (Aug 25, 2023 4:36pm UTC)

Loading

Pipeline #570143 passed

Pipeline passed for a5068b6d on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Shouldn't you also remove the <name>-<version>.dist-info directory generated for packages using pybuild-plugin-pyproject?

    • Author Contributor

      pybuild-plugin-pyproject only does out-of-tree builds, so the generated dist-info metadata is in .pybuild/cpython3_*/build/*-*.dist-info and will be cleaned up by the existing pybuild clean actions.

      There are source packages including dist-info directories but I don't think they would get altered during the build if pybuild-plugin-pyproject is used. Do they get altered by the build if other build systems are used? Is there an example package where this is happening we should look at?

    • Please register or sign in to reply
  • Stuart Prescott added 1 commit

    added 1 commit

    • 7ffdd65b - Require initial . for .egg-info path match

    Compare with previous version

  • Stefano Rivera added 5 commits

    added 5 commits

    • 7ffdd65b...02ee81e4 - 3 commits from branch python-team/tools:master
    • 31eff8fd - Remove *.egg-info directories in clean step
    • a5068b6d - Require initial . for .egg-info path match

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading