Skip to content
Snippets Groups Projects

dpt: unittests: use py3versions -s (instead of -r)

Merged Agathe Porte requested to merge gagath/pypi2deb:fix-py3versions-in-autopkgtests into master

Quoting:

<tumbleweed> my thinking was always that --requested = --supported + the
             possibility of overriding in the package <tumbleweed> so I
             would *always* use --requested
<tumbleweed> but that meant you had to redirect stderr, because it would
             complain if no versions were actually requested in the
             package
<tumbleweed> and then lintian started complaining too
<tumbleweed> in practice we never use those overrides (python language
             changes stopped being so frequent)
Edited by Agathe Porte

Merge request reports

Merged by Sandro TosiSandro Tosi 2 years ago (Aug 21, 2022 5:46am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Agathe Porte changed the description

    changed the description

  • Agathe Porte added 1 commit

    added 1 commit

    • bb9258d6 - dpt: unittests: use py3versions -s (instead of -r)

    Compare with previous version

  • Agathe Porte changed title from dpt: unittests: use py3versions -r (instead of -s) to dpt: unittests: use py3versions -s (instead of -r)

    changed title from dpt: unittests: use py3versions -r (instead of -s) to dpt: unittests: use py3versions -s (instead of -r)

  • posting here the same thing i posted in IRC:

    <morph> gagath: tumbleweed: this is the current situation of py3versions options being used in autopkgtests in dpt:
    <morph>       2 py3versions -
    <morph>       6 py3versions -d
    <morph>      29 py3versions -i
    <morph>     216 py3versions -r
    <morph>       4 py3versions -rv
    <morph>     342 py3versions -s
    <morph>      13 py3versions -sv
    <morph>       1 py3versions -vd
    <morph>       4 py3versions -vi
    <morph>       1 py3versions -vr
    <morph>       3 py3versions -vs
    <morph> so if pypi2deb is to be using --requested instead of --supported, that'd currently be in the _minority_ of the cases :)
    <morph> lintian warning?
    <morph> tbh i wouldnt even spend that much time on this, hopefully the automagic-autopkgtest-via-pybuild is coming Soon?
  • Author Contributor

    Posting here the same thing that was posted on IRC:

    <pollo>	declare-requested-python-versions-for-test recommends replacing -r by -s though
    <pollo>	I think at least in lintian, we're pretty much recommending people use -s

    pypi2deb is actually creating Lintian warnings. Please merge this.

  • merged

  • Sandro Tosi mentioned in commit 59f68234

    mentioned in commit 59f68234

Please register or sign in to reply
Loading