Skip to content
Snippets Groups Projects

Fix Flake8 E741

Closed Raul Benencia requested to merge rul/debsources:py2-eol-flake8 into py2-eol

This commit fixes all occurrences of E741.

To the best of my knowledge the code still works after this changes. I'd like to confirm that through the unit tests but I see that they were already failing. I'll try fixing some of them on my next contribution. 🙂

Merge request reports

Closed by Raul BenenciaRaul Benencia 3 years ago (Mar 31, 2021 5:57pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hey, looks good! I think it'd be wiser to keep this until the py2-eol branch is merged. I'd prefer this branch to only have commits directly related to python3, to some extent. In the meantime, and if that's something in your interests, it'd be awesome to have the Flake8 configuration (and script?) somewhere, that we could also run on a CI pipeline on Salsa. :)

  • Author Contributor

    Hey @matthieucan !

    Yes, that makes sense. In fact, on the weekend I started a branch on my fork to add a CI pipeline, although I didn't make much progress. I'll try to get something solid soon.

    Closing this MR meanwhile.

  • closed

Please register or sign in to reply
Loading