Add CI
Hello!
Some small changes to make the test suite behave with SalsaCI were required:
contrib/docker/Makefile:
- The "run" target now runs docker-compose detached.
- The "tests" target does not need to run interactively.
contrib/docker/scripts/run-tests:
- We need to run only the CI tests here, otherwise producesReferenceDb times out.
.gitmodules:
- Switch from SSH to HTTPS for submodule cloning. SSH connections were not working on my tests.
By the way, I'm not sure if that travis file is still used somewhere. Probably we should rename the make target to "make test-ci" instead of "make test-travis", so it's generic.
Merge request reports
Activity
- Resolved by Matthieu Caneill
- Resolved by Raul Benencia
- Resolved by Raul Benencia
- Resolved by Raul Benencia
It seems that the
producesReferencesDb
test has been failing for years in a CI environment. Check the commit message that added it. I don't think that fixing it should be part of this merge request, though.You have a good point about not being able to run the full test suite anymore, though! I'll see what I can do about that.
added 2 commits
Hello!
I've added two new commits:
- Rename travis attribute to ci: Ideally we don't want the "notravis" attr at all, but I think that's work for another contribution. Given that the CI is now Salsa, I've made this small change to make the naming generic.
- Add main targets on Docker Makefile: we can now call all the targets from the main Makefile from the Docker Makefile. I think that this change enhances consistency.
added 2 commits
Hello
🙂 I've successfully ran all tests with Salsa CI, so I went ahead and removed all
noci
(exnotravis
) attributes and also removed thetest-ci
(extest-travis)
targets. Once this contribution is merged, I think we can go ahead and close #783832.33 33 - bin/debsources-dbadmin --createdb postgresql://postgres@localhost/debsources 34 34 - bin/debsources-update -vv 35 35 36 script: make check test-travis 36 script: make check test-all changed this line in version 4 of the diff
@rul Looks neat, I love it! While we're there, could you
git grep travis
and remove the few unnecessary references? There'setc/config.travis.ini
and some@attr('notravis')
lying around. Then all good to be merged!
enabled an automatic merge when the pipeline for 1b28a2a6 succeeds
mentioned in commit 34e6c0d6