Skip to content
Snippets Groups Projects

Add CI

Merged Raul Benencia requested to merge rul/debsources:add-gitlab-ci into py2-eol
2 unresolved threads

Hello!

Some small changes to make the test suite behave with SalsaCI were required:

contrib/docker/Makefile:

  • The "run" target now runs docker-compose detached.
  • The "tests" target does not need to run interactively.

contrib/docker/scripts/run-tests:

  • We need to run only the CI tests here, otherwise producesReferenceDb times out.

.gitmodules:

  • Switch from SSH to HTTPS for submodule cloning. SSH connections were not working on my tests.

By the way, I'm not sure if that travis file is still used somewhere. Probably we should rename the make target to "make test-ci" instead of "make test-travis", so it's generic.

Merge request reports

Pipeline #248350 passed

Pipeline passed for 1b28a2a6 on rul:add-gitlab-ci

Merged by Matthieu CaneillMatthieu Caneill 3 years ago (Apr 18, 2021 7:08pm UTC)

Loading

Pipeline #248352 passed

Pipeline passed for 34e6c0d6 on py2-eol

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthieu Caneill
  • Author Contributor

    It seems that the producesReferencesDb test has been failing for years in a CI environment. Check the commit message that added it. I don't think that fixing it should be part of this merge request, though.

    You have a good point about not being able to run the full test suite anymore, though! I'll see what I can do about that.

  • Raul Benencia added 2 commits

    added 2 commits

    • c3efe121 - Rename travis attribute to ci
    • 42f6dd9e - Add main targets on Docker Makefile

    Compare with previous version

  • Author Contributor

    Hello!

    I've added two new commits:

    • Rename travis attribute to ci: Ideally we don't want the "notravis" attr at all, but I think that's work for another contribution. Given that the CI is now Salsa, I've made this small change to make the naming generic.
    • Add main targets on Docker Makefile: we can now call all the targets from the main Makefile from the Docker Makefile. I think that this change enhances consistency.
  • Raul Benencia added 2 commits

    added 2 commits

    • 58766d95 - Limit to 100 when querying ctags
    • 4390b229 - Use all tests during CI

    Compare with previous version

  • Raul Benencia resolved all threads

    resolved all threads

  • Author Contributor

    Hello 🙂

    I've successfully ran all tests with Salsa CI, so I went ahead and removed all noci (ex notravis) attributes and also removed the test-ci (ex test-travis) targets. Once this contribution is merged, I think we can go ahead and close #783832.

  • 33 33 - bin/debsources-dbadmin --createdb postgresql://postgres@localhost/debsources
    34 34 - bin/debsources-update -vv
    35 35
    36 script: make check test-travis
    36 script: make check test-all
    • @rul Looks neat, I love it! While we're there, could you git grep travis and remove the few unnecessary references? There's etc/config.travis.ini and some @attr('notravis') lying around. Then all good to be merged!

    • Author Contributor

      Thanks! Done and done. The notravis attributes were already removed. Maybe you were checking an older commit?

    • Please register or sign in to reply
  • Raul Benencia added 1 commit

    added 1 commit

    Compare with previous version

  • Matthieu Caneill enabled an automatic merge when the pipeline for 1b28a2a6 succeeds

    enabled an automatic merge when the pipeline for 1b28a2a6 succeeds

  • mentioned in commit 34e6c0d6

  • Please register or sign in to reply
    Loading