Skip to content
Snippets Groups Projects

Remove obsolete Lintian overrides.

Merged Soren Stoutner requested to merge soren/qt6-webengine:lintian into experimental
1 unresolved thread

This merge request removes a bunch of obsolete Lintian overrides that no longer override anything. In some cases it is because the files in question no longer exist in the source tarball. In other cases it seems that either the files have changed (no longer minified), the unminified source is now shipped in a place that Lintian can find it, or Lintian has gotten smarter about figuring out which JavaScript and HTML files should be flagged.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Soren Stoutner added 14 commits

    added 14 commits

    • 5d4af69a...13a67bf0 - 4 earlier commits
    • 3aa4235d - Refresh patches and remove those that have been applied upstream.
    • 40fa3c06 - Make qtwebengine build with system-libpng (Closes: #1038123).
    • 32e4a3aa - Make qtwebengine build with system-libtiff (Closes: #1033749).
    • 805abafb - Adjustment to override_dh_auto_configure to make it build.
    • dd75dc58 - Update list of installed files.
    • d8358ce4 - Update ABI to 6.6.0 and rename it to qt6-webengine-private-abi.
    • 89ca8b74 - Update symbols from buildlogs and use the (symver) directive to catch all private symbols.
    • a5f9733f - Remove binary package libqt6webenginequickdelegatesqml6.
    • 27685b9a - Fix a lintian override.
    • c2530d87 - Remove obsolete Lintian overrides.

    Compare with previous version

  • Soren Stoutner changed target branch from master to experimental

    changed target branch from master to experimental

  • Soren Stoutner marked this merge request as draft

    marked this merge request as draft

  • Author Maintainer

    I am currently building these changes to check the results. I will remove the draft status when I have reviewed the build.

    • Author Maintainer

      The build fails for me with the following error:

      [28062/30051] CXX obj/third_party/blink/renderer/platform/platform/platform_jumbo_66.o
      FAILED: obj/third_party/blink/renderer/platform/platform/platform_jumbo_66.o 
      /usr/bin/c++ -MMD -MF obj/third_party/blink/renderer/platform/platform/platform_jumbo_66.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_OZONE=1 -DOFFICIAL_BUILD -DTOOLKIT_QT -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DBLINK_PLATFORM_IMPLEMENTATION=1 -DVK_USE_PLATFORM_XCB_KHR -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DLIBYUV_DISABLE_NEON -DWTF_USE_WEBAUDIO_PFFFT=1 -DUSE_INNER_HTML_PARSER_FAST_PATH=1 -DSK_CODEC_DECODES_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_ENABLE_SKSL -DSK_UNTIL_CRBUG_1187654_IS_FIXED -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_WIN_FONTMGR_NO_SIMULATIONS -DSK_GL -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_HAS_WUFFS_LIBRARY -DSK_VULKAN=1 -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE=0 -DHAVE_PTHREAD -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DV8_COMPRESS_POINTERS -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS -DCPPGC_CAGED_HEAP -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION -DCPPGC_SLIM_WRITE_BARRIER -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DWEBRTC_USE_X11 -DLOGGING_INSIDE_WEBRTC -DLEVELDB_PLATFORM_CHROMIUM=1 -DCRASHPAD_ZLIB_SOURCE_EXTERNAL -DUSE_SYSTEM_ZLIB=1 -DUSE_SYSTEM_LIBJPEG -I../../../../../src/3rdparty/chromium/third_party/pffft/src -I. -Igen -I../../../../../src/3rdparty/chromium -I../../../../../src/3rdparty/chromium/third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -Igen/third_party/dawn/include -I../../../../../src/3rdparty/chromium/third_party/dawn/include -I../../../../../src/3rdparty/chromium/third_party/khronos -I../../../../../src/3rdparty/chromium/gpu -I../../../../../src/3rdparty/chromium/third_party/vulkan-deps/vulkan-headers/src/include -I../../../../../src/3rdparty/chromium/third_party/libyuv/include -I../../../../../src/3rdparty/chromium/third_party/jsoncpp/source/include -I../../../../../src/3rdparty/chromium/third_party/abseil-cpp -I../../../../../src/3rdparty/chromium/third_party/boringssl/src/include -I../../../../../src/3rdparty/chromium/third_party/protobuf/src -Igen/protoc_out -I../../../../../src/3rdparty/chromium/third_party/skia -I../../../../../src/3rdparty/chromium/third_party/wuffs/src/release/c -I../../../../../src/3rdparty/chromium/third_party/vulkan/include -I../../../../../src/3rdparty/chromium/third_party/ipcz/include -I../../../../../src/3rdparty/chromium/net/third_party/quiche/overrides -I../../../../../src/3rdparty/chromium/net/third_party/quiche/src/quiche/common/platform/default -I../../../../../src/3rdparty/chromium/net/third_party/quiche/src -Igen/net/third_party/quiche/src -I../../../../../src/3rdparty/chromium/third_party/ced/src -I../../../../../src/3rdparty/chromium/v8/include -Igen/v8/include -I../../../../../src/3rdparty/chromium/third_party/webrtc_overrides -I../../../../../src/3rdparty/chromium/third_party/webrtc -Igen/third_party/webrtc -I../../../../../src/3rdparty/chromium/third_party/libwebm/source -I../../../../../src/3rdparty/chromium/third_party/mesa_headers -I../../../../../src/3rdparty/chromium/third_party/leveldatabase -I../../../../../src/3rdparty/chromium/third_party/leveldatabase/src -I../../../../../src/3rdparty/chromium/third_party/leveldatabase/src/include -I../../../../../src/3rdparty/chromium/third_party/crashpad/crashpad -I../../../../../src/3rdparty/chromium/third_party/crashpad/crashpad/compat/linux -I../../../../../src/3rdparty/chromium/third_party/crashpad/crashpad/compat/non_win -I../../../../../src/3rdparty/chromium/third_party/libaom/source/libaom -I../../../../../src/3rdparty/chromium/third_party/iccjpeg -I../../../../../src/3rdparty/chromium/third_party/ots/src/include -I../../../../../src/3rdparty/chromium/third_party/emoji-segmenter/src -I../../../../../src/3rdparty/chromium/third_party/one_euro_filter/src -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -fno-delete-null-pointer-checks -Wno-comments -Wno-packed-not-aligned -Wno-dangling-else -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -fno-ident -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-unknown-pragmas -Wno-address -Wno-parentheses -Wno-sign-compare -Wno-stringop-overflow -Wno-stringop-overread -Wno-psabi -Wno-multichar -Wno-format-zero-length -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -pthread -m64 -msse3 -fno-omit-frame-pointer -fvisibility=hidden -Wno-unused-variable -O2 -fdata-sections -ffunction-sections -g0 -I/usr/include/nss -I/usr/include/nspr -I/usr/include/libpng16 -I/usr/include/webp -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wno-narrowing -Wno-class-memaccess -Wno-attributes -Wno-class-memaccess -Wno-subobject-linkage -Wno-invalid-offsetof -Wno-return-type -Wno-deprecated-copy -Wno-deprecated-copy -Wno-expansion-to-defined -std=gnu++20 -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c gen/third_party/blink/renderer/platform/platform_jumbo_66.cc -o obj/third_party/blink/renderer/platform/platform/platform_jumbo_66.o
      In file included from gen/third_party/blink/renderer/platform/platform_jumbo_66.cc:7:
      ./../../../../../src/3rdparty/chromium/third_party/blink/renderer/platform/text/text_break_iterator.cc:230:55: error: static assertion failed: breakAllLineBreakClassTable should be consistent
        230 | static_assert(std::size(kBreakAllLineBreakClassTable) == BA_LB_COUNT,
            |                                                       ^
      ./../../../../../src/3rdparty/chromium/third_party/blink/renderer/platform/text/text_break_iterator.cc:230:55: note: the comparison reduces to ‘(40 == 45)’

      This is unlikely to relate to any of the changes in this merge request. Perhaps it has to do with one of the packages in experimental.

    • I've built it successfully a couple of times. Never encountered this error. How did you build it ?

    • Author Maintainer

      I received this error in an sbuild based on experimental. I was unable to build it in an sbuild based on unstable because it depended on a bunch of Qt 6.6.0 packages that are not yet in unstable.

      Edited by Soren Stoutner
    • Weird as I built it the same way (sbuild with added exp).

    • Author Maintainer

      I am going to start another build attempt and see if I receive the same results. It will take several hours on the hardware I have.

    • Author Maintainer

      My build failed with the same error message. Here is a link to the full build log:

      https://nextcloud.stoutner.com/s/GYgfjQMRmbKczTF

    • Our sbuilds differ. You seem to install packages from experimental by default. E.g. I use libdbus-1-dev 1.14.10-3 from unstable whereas you use libdbus-1-dev 1.15.8-3 from experimental.

    • Author Maintainer

      My sbuild has unstable and experimental pinned at the same number, meaning that any package in experimental that is newer than unstable will be used. Let me try a build with experimental pinned lower than unstable.

    • Author Maintainer

      That build fails because it can't find the newer Qt packages.

      https://nextcloud.stoutner.com/s/Li7R5jH9sx7xA62

      My sense is to not worry about this error. It is likely caused because of some problem with some other package in experimental that will be resolved before it is uploaded to unstable. As long as the package builds for you I wouldn't worry about it.

      Edited by Soren Stoutner
    • Please register or sign in to reply
  • Soren Stoutner marked this merge request as ready

    marked this merge request as ready

  • Soren Stoutner added 1 commit

    added 1 commit

    • 917f3c82 - Update libqt6webenginecore6.lintian-overrides

    Compare with previous version

  • Patrick Franz mentioned in commit 316b9135

    mentioned in commit 316b9135

  • merged

  • Please register or sign in to reply
    Loading