Skip to content

Make it possible for default approver to approve on behalf of projects

Célestin Matte requested to merge Perdu/debian-reimbursement:approve_on_behalf into main

tbm requested that SPI can approve requests on behalf of projects, e.g. when they confirm via email. I'd rather not use the admin group for that, to keep a separation between admins and treasurer.

For this, I:

  • added a "defaultapprover" field in user_access, True when user is in the settings.DEFAULT_APPROVER group.
  • changed the text on the button to make it clear that you're approving on behalf of the normal approver (also applied when approver is admin).

I'm unsure whether to reuse the DEFAULT_APPROVER setting to keep things simple or add another setting to make it clearer in terms of semantics. What do you think?

Merge request reports