Skip to content
Snippets Groups Projects
  • Mattia Rizzolo's avatar
    269864b7
    Revert "diffoscope/comparators/symlink.py: added a try except block to track" · 269864b7
    Mattia Rizzolo authored
    Copying the comment from
    659d1917:
    
        @Vibhu-guest also I'm reverting this one, mostly because the
        authoring information is screwed (root <root@localhost.localdomain> -
        does this mean you are doing your work as root??), and should have
        probably be gone through an MR instead of being pushed to master.
    
        I'm also at odds about the changes themselves.  You are catching
        that OSError in those two fairly specific positions, but it feels
        rather arbitrary.  Surely ENOSPC could happen anywhere?
    
        Finally, I think the user at the end should at least getting
        something that tells them what the problem is.  I think this way the
        program terminates without printing anything?
    
    This reverts commit 659d1917.
    269864b7
    History
    Revert "diffoscope/comparators/symlink.py: added a try except block to track"
    Mattia Rizzolo authored
    Copying the comment from
    659d1917:
    
        @Vibhu-guest also I'm reverting this one, mostly because the
        authoring information is screwed (root <root@localhost.localdomain> -
        does this mean you are doing your work as root??), and should have
        probably be gone through an MR instead of being pushed to master.
    
        I'm also at odds about the changes themselves.  You are catching
        that OSError in those two fairly specific positions, but it feels
        rather arbitrary.  Surely ENOSPC could happen anywhere?
    
        Finally, I think the user at the end should at least getting
        something that tells them what the problem is.  I think this way the
        program terminates without printing anything?
    
    This reverts commit 659d1917.