Skip to content

WIP: Add missing test for RE_SYMBOL_COMMENT, rename it to DISCARD_SYMBOL_COMMENT

test_source.py: skip source files

Don't fail when developers provide the source with the binaries.

(Compiled C code is highly toolchain dependent so we can't always compile at test time, sometimes we have to check in binaries. Discuss in #66 )

Add missing test for RE_SYMBOL_COMMENT, rename it to DISCARD_SYMBOL_COMMENT

Before this new test you could purposedly break the regular expression yet all tests would still pass.

I considered generating the .so files at test time as recommended in #66 however my experience with toolchains tells me their outputs are too variable/unstable. This commit does include the source code and the < 10 lines shell script that produces the .so files but it's not compiled every time at test time.

Speaking of toolchain variability, the original test provided in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808207 (and never checked in?) didn't produce any difference to filter with my toolchain. It couldn't reproduce anything anymore because qux@@Base kept the same (aligned) location. So I made up this test instead.

Edited by Chris Lamb

Merge request reports

Loading