Skip to content
Snippets Groups Projects
Verified Commit ef5ae496 authored by Mattia Rizzolo's avatar Mattia Rizzolo
Browse files

Adapt tests to the output of gnumeric 1.12.43

parent 89e7e67e
No related branches found
No related tags found
No related merge requests found
Pipeline #20231 failed
Loading
  • Owner
  • Author Owner

    that URL 404s for me…?

    (and also locally it gives unknown commit e9d3062)

  • Owner

    Oh, race condition… 255cbe59

  • Author Owner

    Ah, I see what you meant there. But that wouldn't have been enough, as also the values in the diff headers are different (i.e. @@ -1 +1 @@ vs @@ -1,3 +1,3 @@)

  • Author Owner

    but now, doesn't adding that .strip() make the new test of mine fail?

  • Owner

    It does. Reverted it in 344ae4d6.

    (The .strip() /when I wrote it/ did cause the test to succeed as planned, but perhaps I didn't think about those diff headers which were not changing for me... the strip surely occurrs before diff is called anyway?)

  • Author Owner

    Oh right. I think I was thinking of me while I was looking at fixing it, I did try to add a diff, but I must have placed it somewhere different (clearly after diff was called…)

    Anyway, if you think your fix is better, do feel free to revert my change and add yours!

  • Chris Lamb :eyes: @lamby

    mentioned in commit 47588095

    ·

    mentioned in commit 47588095

    Toggle commit list
  • Owner

    Done in 47588095. Again, sorry about the mess...

  • Author Owner

    Instead, thank you for solving the issue in a much smaller (!) commit than mine!

0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment