speakersafetyd: d/rules: override dh_installsystemd

I talked to the Asahi team, and was told that speakersafetyd.service should never be enabled in systemd, but rather only triggered by the udev rules. (I myself had issues caused by the service failing when running in a VM). This MR implements this requirement. Installation of the systemd service is done within the execute_after_dh_install target, so overriding dh_installsystemd only disables auto-activation and auto-start of the service.

cc/ @tobhe @ah

Thanks for looking into this!

added 1 commit

• 0c8e36fa - speakersafetyd: d/rules: override dh_installsystemd

Compare with previous version

resolved all threads

approved this merge request

added 32 commits

• 0c8e36fa...409eb465 - 30 commits from branch rust-team:master
• 598ee5ff - speakersafetyd: d/rules: override dh_installsystemd
• 9bcb3045 - speakersafetyd: add d/RFS

Compare with previous version

Looking at this a second time, I wonder: Should we also disable speakersafetyd.service on upgrades from old versions?

eg. something like this:

> cat debian/postinst 
#!/bin/sh
set -e

if [ "$1" = "configure" ] && [ -n "$2" ] && dpkg --compare-versions -- "$2" le-nl "0.1.9-2~"; then
	# previous version mistakenly enabled speakersafetyd.service on install
	# This can be dropped in trixie+1
	if deb-systemd-helper --quiet was-enabled 'speakersafetyd.service'; then
		deb-systemd-helper disable 'speakersafetyd.service' >/dev/null || true
	fi
fi


#DEBHELPER#

Can someone verify the started state is the same of speakersafetyd.service after upgrade with speakersafetyd running and not running while upgrading?

PS. Please answer "why" (not "what" - which can be seen in commit/source diff) in debian/changelog (and/or commit messages)!

added 47 commits

• 9bcb3045...a546e313 - 43 commits from branch rust-team:master
• 68707d4a - speakersafetyd: d/rules: do not enable speakersafetyd.service on install
• b157b0fd - speakersafetyd: add d/RFS
• d62c2a15 - speakersafetyd: d/postinst: disable speakersafetyd.service on upgrades...
• dc36df3b - speakersafetyd: d/debcargo.toml: fix long description indentation

Compare with previous version

resolved all threads

@ah can this be merged ?

No objections to the changes so far. I just dont have time to review of there are any final touches that could be useful.... I guess they can always come later, so feel free to merge and upload if you would like to proceed!

can't upload; just lgtm to merge at least

Sorry, didn't see these messages and pushed a small change after them: I moved postinst to speakersafetyd.postinst as requested. Thank you.

@ah will merge unless you object

added 2 commits

• 02847ac9 - speakersafetyd: d/speakersafetyd.postinst: disable speakersafetyd.service...
• 62ecabfd - speakersafetyd: d/debcargo.toml: fix long description indentation

Compare with previous version

merged

mentioned in commit 34351de3