Skip to content

Package tiny-dfr (update and complete)

Noisy Coil requested to merge NoisyCoil/debcargo-conf:package-tiny-dfr into master

This MR updates and completes @ah's !564 (closed). It packages tiny-dfr and its missing dependencies.

The new dependencies are as follows:

  • tiny-dfr
    • drm
      • drm-ffi
        • drm-sys
      • drm-fourcc
    • input (merged, waiting for upload but changed by this MR)
      • input-sys (merged, waiting for upload but changed by this MR)
    • input-linux
      • input-linux-sys
    • input-linux-sys
    • privdrop

With respect to ah's previous MR, this MR:

  • updates some crate versions, most notably tiny-dfr itself
  • aligns other dependencies with what is currently in unstable, e.g. nix and bindgen, also in packages which are currently merged but not uploaded yet
  • fixes autopkgtest errors (more on this below)
  • completes the packaging of tiny-dfr (more on this below)

Small changes to ah's previous MR are done via fixup! commits which can be autosquashed before merge.

As for the new stuff, in tiny-dfr I added d/install to install the systemd service, udev rules and data files, d/rules so that the service is not enabled on install, and d/postinst so that the service is started on install based on the udev rules. The logic is the same as the one currently in use by speakersafetyd, with obvious changes.

In drm-ffi and drm-sys autopkgtests I jointly fixed an upstream issue (first mentioned in !564 (comment 459279)) by backporting this patch, but I could not fix another issue related to filesystem permissions: autopkg tests still fail for drm-fourcc and drm-sys during bindings generation with error messages

[drm-fourcc 2.2.0] thread 'main' panicked at build.rs:9:26:
[drm-fourcc 2.2.0] called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }
[drm-sys 0.6.1] thread 'main' panicked at build.rs:166:41:
[drm-sys 0.6.1] called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }

Similarly, autopkgtests for input-sys (already merged, not uploaded yet) spit out

[input-sys 1.17.0] thread 'main' panicked at build.rs:106:46:
[input-sys 1.17.0] called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }

(All autopkgtest failures have been fixed.)

In drm-fourcc and input-sys, updating bindgen required renaming some whitelist functions to allowlist.

This MR can successfully build tiny-dfr (and hopefully package it in a way that works for real hardware), so it is ready for review. Whether or not it is ready for merge depends on the policy on autopkgtest failures, which I known nothing about.

Edited by Noisy Coil

Merge request reports