Skip to content
Snippets Groups Projects

pyo3 (and part of the ecosystem): upgrade to 0.21.1

Open Antonio Russo requested to merge aerusso/debcargo-conf:mrs/pyo3-0.21.2-et-am into master
2 unresolved threads

This drops the in-tree (but unreleased) version from 0.22.0 to 0.21.1, since the rest of the pyo3 ecosystem doesn't appear to be there yet.

pep508_rs is experiencing an package test failure, but I'm not yet quite skilled enough to understand what is going on there.

pep508 and pep440 required new packages, packaged here.

pythonize, pyo3-log, and pyproject-toml also get upgrades

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Fabian Grünbichler
    Fabian Grünbichler @fg started a thread on commit 3347168c
  • Fabian Grünbichler
    • it's always nice to give the order of things for bigger MRs, else a reviewer has to find out on their own which is extra work ;)

      FWIW, I tested using the following order:

      pyo3-build-config
      pyo3-ffi
      pyo3-macros-backend
      pyo3-macros
      pyo3
      pyo3-log
      unscanny
      pep440_rs
      pubgrub
      pep508_rs
      pythonize
      pyproject-toml

      noted a few small things, in addition to those:

      • pyo3 is patched to use memoffset 0.6, unstable has 0.8 now -> needs a small fix
      • pyo3 has a few patches which are not referenced in the series file (?)
      • pyo3 triggers a lintian check that might be overridden or handled (executable-not-elf-or-script, probably those .rs files shouldn't be executable..)
      • the failing pep508_rs test case for the tracing feature seems to be either a lacking feature guard (for the pyo3 feature in addition to the tracing feature), or a missing dep for the tracing feature (to enable tracing/log, like the pyo3 feature does). when in doubt, asking upstream seems fair, and choosing one of the two for now or marking that particular test invocation as broken all seem like valid options to proceed
    • Author Contributor
      1. This was fixed by a rebase.
      2. I've removed the one still remaining.
      3. I've modified debian/rules to chmod -x those files after dh_install. Is that acceptable?
      4. I've added a pyo3 feature guard for now.
    • Please register or sign in to reply
  • Fabian Grünbichler requested review from @fg

    requested review from @fg

  • Antonio Russo added 184 commits

    added 184 commits

    Compare with previous version

  • Please register or sign in to reply
    Loading