Drop using aptitude and mk-build-deps
* avoid installing devscripts, equivs, aptitude and dependencies in the build chroot. Compared to a chroot that only contains Essential, apt and build-essential a chroot with these packages contains 114 additional binary packages. This means that it was possible that a salsaci job does not error out if a developer forgot to add a build dependency if it happens to be one of those 114 packages (false positive). * when only building architecture dependent packages in the test-build-any job, only Build-Depends and Build-Depends-Arch must be installed and Build-Conflicts-Indep must be ignored. When only building architecture independent packages in the test-build-all job, only Build-Depends and Build-Depends-Indep must be installed and Build-Conflicts-Arch must be ignored. This was not respected before this commit due to bug #980058 in mk-build-deps. This leads to similar false-positive builds like the last point and wrong build dependency declarations will remain unnoticed until the source package is built on the buildds. * also similarly to the last point, salsaci was wrongly installing Build-Depends-Indep when doing cross builds. This lead to failing cross builds for packages that moved their unsatisfiable cross-build dependencies to Build-Depends-Indep because they were only needed to build arch:all binary packages. * when building packages for experimental, the official buildds use aspcud as the dependency resolver. Since salsaci was not doing the same, this lead to different behaviour compared to the buildds. This commit replaces mk-build-deps with a call to apt-get build-dep with the right option depending on the desired package build. Thanks to IOhannes zmölnig (@umlaeute) for invaluable input that made this commit possible in the first place. Thanks to Iñaki Malerba (@ina) for the review and small fixes. Closes: #198
Showing
- images/dockerfiles/base.0 0 additions, 3 deletionsimages/dockerfiles/base.0
- images/dockerfiles/gbp.0 0 additions, 2 deletionsimages/dockerfiles/gbp.0
- images/scripts/install-build-deps.sh 0 additions, 41 deletionsimages/scripts/install-build-deps.sh
- salsa-ci.yml 28 additions, 9 deletionssalsa-ci.yml
Loading
-
mentioned in issue #234 (closed)
-
mentioned in merge request !321 (merged)
-
mentioned in commit mariadb-team/mariadb-server@8bafa4cf
-
mentioned in commit mariadb-team/mariadb-server@bfa052d2
-
mentioned in commit mariadb-team/mariadb-server@589dc47d
-
mentioned in commit mariadb-team/mariadb-server@24f38813
-
mentioned in commit mariadb-team/mariadb-server@eab89f14
-
mentioned in commit mariadb-team/mariadb-server@04db04ec
-
mentioned in commit mariadb-team/mariadb-server@8be4fb72
Please register or sign in to comment