Commits on Source (37)
-
Stefan Metzmacher authored
and re-enable GIT_SNAPSHOT. Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(v4-21-test): Stefan Metzmacher <metze@samba.org> Autobuild-Date(v4-21-test): Tue Aug 13 16:55:05 UTC 2024 on atb-devel-224
cf4feb17 -
Shachar Sharon authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15686 Signed-off-by: Shachar Sharon <ssharon@redhat.com>
12084aa1 -
Anoop C S authored
winbind_ctdb_updatekeytab.sh assumes the presence `onnode` utility to execute `net ads` command on all nodes in the cluster. But `onnode` is only built when configured with clustering support. Therefore perform the script installation only with ctdb configuration. Also fix the installation path to /usr/share/ctdb/scripts. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15689 Signed-off-by: Anoop C S <anoopcs@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org> (cherry picked from commit 3929fdae1a13ab029e173ce53598d3fa6cf40e9c)
c7e6ec6b -
Anoop C S authored
Update the change in installation path for winbind_ctdb_updatekeytab.sh from SAMBA_DATADIR to newly defined CTDB_DATADIR. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15689 Signed-off-by: Anoop C S <anoopcs@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Fri Aug 16 09:49:30 UTC 2024 on atb-devel-224 (cherry picked from commit 31c9352099f5efeb88d27c603ec2dbfaf98b300d)
fcca9820 -
Pavel Filipenský authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15689 Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Pavel Filipensky <pfilipensky@samba.org> Autobuild-Date(master): Mon Aug 19 13:21:08 UTC 2024 on atb-devel-224 (cherry picked from commit f1cd250a6fd7e0571bd22493c838d6c12c2adf5b)
294f9e47 -
Stefan Metzmacher authored
This shows that all compound related requests should get NT_STATUS_NETWORK_SESSION_EXPIRED. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15696 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit f6009aa73b9234df1e6ab689de322487ad1394ed)
64416b69 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15696 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Aug 13 22:29:28 UTC 2024 on atb-devel-224 (cherry picked from commit 4df1bfd07012dd3d2d2921281e6d6e309303b88d) Autobuild-User(v4-21-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-21-test): Tue Aug 20 09:04:48 UTC 2024 on atb-devel-224
38055454 -
Jule Anger authored
Signed-off-by: Jule Anger <janger@samba.org>
21a75c2b -
Jule Anger authored
Signed-off-by: Jule Anger <janger@samba.org>
bb4874ba -
Jule Anger authored
and re-enable GIT_SNAPSHOT. Signed-off-by: Jule Anger <janger@samba.org>
851c488e -
Pavel Filipenský authored
Same fix as in commit 09d76905 'samba-tool domain provision -d10' fails if the included file does not exist: lpcfg_load: refreshing parameters from /etc/samba/smb.conf Processing section "[global]" Can't find include file /etc/samba/usershares.conf pm_process() returned No ERROR: Unable to load default file File "/usr/lib64/python3.12/site-packages/samba/netcmd/domain/provision.py", line 183, in run lp = sambaopts.get_loadparm() ^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.12/site-packages/samba/getopt.py", line 282, in get_loadparm self._lp.load_default() BUG: https://bugzilla.samba.org/show_bug.cgi?id=15698 Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Wed Aug 21 00:04:19 UTC 2024 on atb-devel-224 (cherry picked from commit ffc75c569c69ce22a39b5d1df8cb4906095c8654) Autobuild-User(v4-21-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-21-test): Wed Aug 21 11:19:48 UTC 2024 on atb-devel-224
0d41094f -
Shachar Sharon authored
When VFS readlinkat hook returns with error the following sequence yields NULL-pointer dereference (SIGSEGV): symlink_target_below_conn (source3/smbd/open.c) char *target = NULL; ... readlink_talloc (source3/smbd/files.c) SMB_VFS_READLINKAT smb_vfs_call_readlinkat (source3/smbd/vfs.c) handle->fns->readlinkat_fn --> returns error status = safe_symlink_target_path(.., target /* NULL */ ..) safe_symlink_target_path (source3/smbd/filename.c) if (target[0] == '/') { /* NULL pointer dereference */ A failure in VFS module's readlinkat hook may happen due to run-time error (e.g., network failure which cases libcephfs to disconnect from MDS). Bug: https://bugzilla.samba.org/show_bug.cgi?id=15700 Signed-off-by: Shachar Sharon <ssharon@redhat.com> Reviewed-by: John Mulligan <jmulligan@redhat.com> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Aug 23 09:27:06 UTC 2024 on atb-devel-224 (cherry picked from commit 168966a053045476a84044aa73f66722eb702fe0) Autobuild-User(v4-21-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-21-test): Mon Aug 26 11:09:31 UTC 2024 on atb-devel-224
37bbe0ca -
Jule Anger authored
Signed-off-by: Jule Anger <janger@samba.org>
a8dda787 -
Jule Anger authored
Signed-off-by: Jule Anger <janger@samba.org>
5bb01bb6 -
Jule Anger authored
and re-enable GIT_SNAPSHOT. Signed-off-by: Jule Anger <janger@samba.org>
d7f49d90 -
Noel Power authored
On tumbleweed at least the definition in py_reparse_put of 'reserved' as 'unsigned' causes the tag value to be overwritten. Note: ParseTuple is given a format of 'Kk' where K = unsigned long long (for tag) k = unsigned long (for reserved) The problem is 'reserved' is defined as 'unsigned' which on a 64 bit linux system has size 4. The size however of the 'unsigned long' type on the same 64 bit system is 8. This causes 'tag' to be overwritten by the value of 'reserved' because it's destination size is smaller than expected. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15702 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Wed Aug 28 18:38:01 UTC 2024 on atb-devel-224 Autobuild-User(v4-21-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-21-test): Thu Aug 29 13:10:29 UTC 2024 on atb-devel-224
eed4dfe3 -
David Disseldorp authored
FSCTL_QUERY_ALLOCATED_RANGES responses with more than one range should be truncated to account for a ioctl.smb2.in.max_output_response limit. Add a test for this. Flag the new test knownfail; fix in subsequent commit. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Noel Power <npower@samba.org> (cherry picked from commit 5cf57f1f539021f1490285516d8cfb2a2ab483e0)
b6ebcd63 -
David Disseldorp authored
As per MS-FSA 2.1.5.10.22 FSCTL_QUERY_ALLOCATED_RANGES, if response range entries exceed in_max_output, then we should respond with STATUS_BUFFER_OVERFLOW and a truncated output buffer. Bug: https://bugzilla.samba.org/show_bug.cgi?id=15699 Reported-by: David Howells <dhowells@redhat.com> Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Noel Power <npower@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Wed Aug 28 08:54:11 UTC 2024 on atb-devel-224 (cherry picked from commit 5e278a52646a48e3671270e5b57ec5b852f9fb4b) Autobuild-User(v4-21-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-21-test): Thu Aug 29 15:30:50 UTC 2024 on atb-devel-224
10dddd55 -
Jule Anger authored
This reverts commit 10dddd55. Wrong patchset applied. This is the one for 4.19/4.20. The correct patch set will be the subsequent commits. See: https://bugzilla.samba.org/show_bug.cgi?id=15699 Signed-off-by: Jule Anger <janger@samba.org>
c9bc9150 -
Jule Anger authored
This reverts commit b6ebcd63. Wrong patchset applied. This is the one for 4.19/4.20. The correct patch set will be the subsequent commits. See: https://bugzilla.samba.org/show_bug.cgi?id=15699 Signed-off-by: Jule Anger <janger@samba.org>
1bddcb30 -
David Disseldorp authored
FSCTL_QUERY_ALLOCATED_RANGES responses with more than one range should be truncated to account for a ioctl.smb2.in.max_output_response limit. Add a test for this. Flag the new test knownfail; fix in subsequent commit. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Noel Power <npower@samba.org> (cherry picked from commit 5cf57f1f539021f1490285516d8cfb2a2ab483e0)
d231f0c8 -
David Disseldorp authored
As per MS-FSA 2.1.5.10.22 FSCTL_QUERY_ALLOCATED_RANGES, if response range entries exceed in_max_output, then we should respond with STATUS_BUFFER_OVERFLOW and a truncated output buffer. Bug: https://bugzilla.samba.org/show_bug.cgi?id=15699 Reported-by: David Howells <dhowells@redhat.com> Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Noel Power <npower@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Wed Aug 28 08:54:11 UTC 2024 on atb-devel-224 (cherry picked from commit 5e278a52646a48e3671270e5b57ec5b852f9fb4b)
b2ce6308 -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org>
66ae6948 -
Andrew Bartlett authored
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
8423ea48 -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
acf8afd4 -
Andrew Bartlett authored
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
3f9b358f -
Andrew Bartlett authored
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
9c92d2b5 -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
9a042a5d -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
b76a5d99 -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org>
b904a17d -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org>
99e23f67 -
Jennifer Sutton authored
Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
83a08984 -
Shachar Sharon authored
Commit d00f20f3 ("vfs_ceph_new: debug-log upon libcephfs low-level calls") introduced debug-logging before each call to libcephfs low-level APIs. Unfortunately, one of the logging messages missed the terminating newline ('\n') character. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15686 Signed-off-by: Shachar Sharon <ssharon@redhat.com> Reviewed-by: John Mulligan <jmulligan@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Wed Aug 21 14:18:07 UTC 2024 on atb-devel-224 (cherry picked from commit cbba4008a7fb9e6e91d0568f25ac481b60fda96f)
06cf7b7b -
Shachar Sharon authored
Commit 53c9269b (vfs_ceph_new: use low-level APIs for symlink/readlink) introduced readlinkat using libcephfs low-level APIs. However, it does not handle properly the case where readlinkat operates on empty name string (see man readlinkat(2)), such as: fd = openat(dirfd, symname, O_PATH | O_NOFOLLOW, 0); readlinkat(fd, "", buf, bufsiz); Handle this special case of readlinkat with empty name string by using a reference to the symlink inode itself. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15686 Signed-off-by: Shachar Sharon <ssharon@redhat.com> Reviewed-by: Anoop C S <anoopcs@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Fri Aug 30 10:42:27 UTC 2024 on atb-devel-224 (cherry picked from commit 22182f90e8e7876a9895f77e736d2b96b18b174f) Autobuild-User(v4-21-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-21-test): Mon Sep 2 10:01:41 UTC 2024 on atb-devel-224
6071ea83 -
Jule Anger authored
Signed-off-by: Jule Anger <janger@samba.org>
1bb2ce3b -
Jule Anger authored
Signed-off-by: Jule Anger <janger@samba.org>
1c7d4b5b -
Michael Tokarev authored45b7c315
Showing
- VERSION 1 addition, 1 deletionVERSION
- WHATSNEW.txt 198 additions, 13 deletionsWHATSNEW.txt
- docs-xml/generate-pathconf-entities.sh 1 addition, 0 deletionsdocs-xml/generate-pathconf-entities.sh
- docs-xml/smbdotconf/security/syncmachinepasswordscript.xml 2 additions, 2 deletionsdocs-xml/smbdotconf/security/syncmachinepasswordscript.xml
- dynconfig/wscript 5 additions, 0 deletionsdynconfig/wscript
- lib/param/loadparm.c 1 addition, 1 deletionlib/param/loadparm.c
- libcli/smb/py_reparse_symlink.c 1 addition, 1 deletionlibcli/smb/py_reparse_symlink.c
- source3/libads/kerberos_keytab.c 3 additions, 2 deletionssource3/libads/kerberos_keytab.c
- source3/modules/vfs_ceph_new.c 23 additions, 12 deletionssource3/modules/vfs_ceph_new.c
- source3/script/wscript_build 3 additions, 1 deletionsource3/script/wscript_build
- source3/smbd/open.c 4 additions, 0 deletionssource3/smbd/open.c
- source3/smbd/smb2_ioctl.c 3 additions, 1 deletionsource3/smbd/smb2_ioctl.c
- source3/smbd/smb2_ioctl_filesys.c 33 additions, 21 deletionssource3/smbd/smb2_ioctl_filesys.c
- source3/smbd/smb2_server.c 15 additions, 1 deletionsource3/smbd/smb2_server.c
- source4/libcli/smb2/ioctl.c 2 additions, 1 deletionsource4/libcli/smb2/ioctl.c
- source4/torture/smb2/ioctl.c 148 additions, 1 deletionsource4/torture/smb2/ioctl.c
- source4/torture/smb2/session.c 56 additions, 0 deletionssource4/torture/smb2/session.c