Commits on Source (99)
-
Jule Anger authored
and re-enable GIT_SNAPSHOT. Signed-off-by: Jule Anger <janger@samba.org>
6875787d -
Stefan Metzmacher authored
This should have been in commit: 6ca4df63 Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(v4-19-test): Stefan Metzmacher <metze@samba.org> Autobuild-Date(v4-19-test): Wed Jul 3 08:36:32 UTC 2024 on atb-devel-224
fecc211a -
Stefan Metzmacher authored
We just destroy the signature bytes but keep the header unchanged. This makes it easier to look at it in wireshark. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit ae23d512)
1c807412 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit c594cbad)
1800543b -
Stefan Metzmacher authored
With socket_wrapper we only get 1500 byte chunks... BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit c741d0f3)
313ca15a -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit ce591464)
606b7034 -
Stefan Metzmacher authored
Failed DNS updates just echo the request flaged as response, all other elements are unchanged. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 6e997f93)
fdac5897 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit f8dfa9b3)
b1222378 -
Stefan Metzmacher authored
It's possible to put the additional into the answers section, so we should be able to test that. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit cd747307)
a086e96f -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 27d92fa8)
48be174b -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 1b1e7e06)
2741574e -
Stefan Metzmacher authored
This will allow tests to backup the whole state and mix them. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit b0af60e7)
16c21888 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 740bda87)
e120078e -
Stefan Metzmacher authored
Also test using the additional record in the answers section. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 3c7cb85e)
f984b281 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit b9b03ca5)
eb18b228 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit de4ed363)
4bc0619b -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 8324d073)
4d4b39c1 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 84831833)
0ee7660f -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 88457da0)
e50968ed -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 753428a3)
d5c6276f -
Stefan Metzmacher authored
This demonstrates that access_denied is only generated if the client really generates a change in the database. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 708a6fae)
4a7d14ef -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit a56627b0)
662c4675 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit fa0f23e6)
234503e2 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 3467d149)
cbf10a68 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit bd0235cd)
7a457c68 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit ae7538af)
288744a7 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 5906ed94)
c7188e17 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit db350bc5)
6d3d87ba -
Stefan Metzmacher authored
This means we no longer generate strange errors/warnings in the Windows event log nor in the nsupdate -g output. Note: this is a only difference between gss-tsig and the legacy gss.microsoft.com algorithms. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 76fec266)
c29dc6e7 -
Stefan Metzmacher authored
If the client does not have permissions to update the record, but the record already has the data the update tries to apply, it's a no-op that should result in success instead of failing. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13019 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Jun 6 03:18:16 UTC 2024 on atb-devel-224 (cherry picked from commit ed61c57e)
fd586087 -
Noel Power authored
On master attempting to chdir into a nested dfs link e.g. cd dfslink (works) cd dfslink/another_dfslink (fails) [1] Add a test for this scenario (nested chdir) [2] Add test for enumerating a dfs link in root of dfs share [3] Add a test to check case insensitive chdir into dfs link on widelink enabled share Add knownfails for tests 1 and 3 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15435 (cherry picked from commit 7f1de90f) [noel.power@suse.com backported to Samba 4.19 changed knownfails because test_ci_chdir doen't fail in 4.19 but test_enumerate_dfs_link does]
6c86b519 -
Noel Power authored
This patch also removes known fail for existing test BUG: https://bugzilla.samba.org/show_bug.cgi?id=15435 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Jun 11 19:31:40 UTC 2024 on atb-devel-224 (cherry picked from commit 788ef8f0) [noel.power@suse.com backported to Samba 4.19 changed test of errno after return from widelink_openat to ENOENT because ELOOP isn't set for msdfs links in 4.19, ENOENT is set instead. Also minor change to use 4.19 create_open_symlink_err fn instead of read_symlink_reparse]
dfa0b1ad -
Stefan Metzmacher authored
A lot of stuff is private to nmbd and can be moved from nameserv.h. This allows move required types from smb.h to nameserv.h, so that this can be standalone. Including it from smb.h is not a huge problem as nmbd internals are gone from nameserv.h. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 7f96c210)
7e076141 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 105247c9)
39789dce -
Stefan Metzmacher authored
We need to make this explicit in order to let LIBNMB be used in source4 code. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 011f68ae)
5de4ae88 -
Stefan Metzmacher authored
It's not needed and it requires the caller to setup a stackframe... BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit f90cf082)
8c06b437 -
Stefan Metzmacher authored
s3:libsmb/unexpected: pass nmbd_socket_dir from the callers of nb_packet_{server_create,reader_send}() This will allow source4/nbt_server to make use of nb_packet_server_create(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 696505a1)
8b39131d -
Stefan Metzmacher authored
In 2024 we always want an active directory response... BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 2b66663c)
12a6060e -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit cca373b8)
e2cec0d2 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 11861bcf)
1d766f29 -
Stefan Metzmacher authored
This avoids talloc_reference... BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 77f4f1c7)
a308204a -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit bfb10774)
9a9dc998 -
Stefan Metzmacher authored
This is needed in order to let nbt_getdc() work against another AD DC and get back a modern response with DNS based names. Instead of falling back to the ugly name_status_find() that simulates just an NETLOGON_SAM_LOGON_RESPONSE_NT40 response. This way dsgetdcname() can work with just the netbios domain name given and still return an active directory response. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15620 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 796f33c0)
7ccbbb4b -
Andrew Bartlett authored
These options are for packagers and vendors to set so that when Samba developers are debugging an issue, we know exactly which package is in use, and so have an idea if any patches have been applied. This is included in the string that a Samba backtrace gives, as part of the PANIC message. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15654 REF: https://lists.samba.org/archive/samba-technical/2024-May/138992.html Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> (cherry picked from commit 651fb94c)
80655e22 -
Andrew Bartlett authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15654 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> RN: We have added new options --vendor-name and --vendor-patch-revision arguments to ./configure to allow distributions and packagers to put their name in the Samba version string so that when debugging Samba the source of the binary is obvious. [abartlet@samba.org adapted to 4.20 still having the seperate LDB build system from commit 72112d48]
f525d2fe -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15664 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Noel Power <noel.power@suse.com> (cherry picked from commit 372476ae)
1af40f29 -
Stefan Metzmacher authored
If a client for whatever reason calls FSCTL_SRV_COPYCHUNK[_WRITE] without FSCTL_SRV_REQUEST_RESUME_KEY, we call vfswrap_offload_write_send before vfswrap_offload_read_send. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15664 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Noel Power <noel.power@suse.com> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 17 18:02:27 UTC 2024 on atb-devel-224 (cherry picked from commit 462b74da)
ac5efd03 -
Günther Deschner authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15665 RADOS objects within a pool can be associated to a namespace for logical separation. librados already provides an API to configure such a namespace with respect to a context. Make use of it as an optional argument to the helper binary. Pair-Programmed-With: Anoop C S <anoopcs@samba.org> Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> (cherry picked from commit d8c52995)
0597a2a6 -
Günther Deschner authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15665 Document the new optional argument to specify the namespace to be associated with RADOS objects in a pool. Pair-Programmed-With: Anoop C S <anoopcs@samba.org> Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Fri Jun 14 07:42:25 UTC 2024 on atb-devel-224 (cherry picked from commit 35f6c3f3)
28fbc8ff -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15666 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit cda8beea)
bfe5ad43 -
Stefan Metzmacher authored
This shows that they are ignored for machine accounts as domain member. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15666 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit db2c576f)
b79e3492 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15666 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit c715ac5e)
20fcb8f8 -
Stefan Metzmacher authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15666 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> (cherry picked from commit eeb60574)
b3519d06 -
Stefan Metzmacher authored
We only turn desired into off in the NT4 domain member case. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15666 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Jun 19 10:17:28 UTC 2024 on atb-devel-224 (cherry picked from commit 5b40cdf6)
bb5414a6 -
Jo Sutton authored
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 849ee959) BUG: https://bugzilla.samba.org/show_bug.cgi?id=15655
fc8beb13 -
Jo Sutton authored
These should help to catch mistaken attempts to set invalid attributes. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 2b69e1e7) BUG: https://bugzilla.samba.org/show_bug.cgi?id=15655
a35edbb5 -
Andrew Bartlett authored
This allows us to have tests, which pass on Windows, that use a very short maxPwdAge. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit 3669479f) BUG: https://bugzilla.samba.org/show_bug.cgi?id=15655
e65a4281 -
Jo Sutton authored
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 7cc8f455) BUG: https://bugzilla.samba.org/show_bug.cgi?id=15655
9c64cd3f -
Andrew Bartlett authored
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (backported from commit b2fe1ea1) BUG: https://bugzilla.samba.org/show_bug.cgi?id=15655 [jsutton@samba.org Fixed conflicting import statements in python/samba/tests/krb5/pkinit_tests.py] [jsutton@samba.org Fixed conflicting import statements in python/samba/tests/krb5/kdc_base_test.py]
2102b619 -
Jo Sutton authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15655 Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> (backported from commit 6dc61687) [jsutton@samba.org Fixed conflicting import statements in python/samba/tests/krb5/kdc_base_test.py] [jsutton@samba.org Fixed conflicting import statements in python/samba/tests/krb5/kdc_base_test.py]
7cc2b7b0 -
Jo Sutton authored
Heimdal matches Windows in the no‐FAST case, but produces NTSTATUS codes when it shouldn’t in the FAST case. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15655 Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> (backported from commit c5ee0b60) [jsutton@samba.org Fixed conflicts in selftest/knownfail_heimdal_kdc]
86034d86 -
Jo Sutton authored
third_party/heimdal: Import lorikeet-heimdal-202406240121 (commit 4315286377278234be2f3b6d52225a17b6116d54) This lets us match the Windows FAST reply when the password is expired. Windows clients were upset by the NTSTATUS field in the edata, apparently interpreting it to mean “insufficient resource”. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15655 Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> (backported from commit fe905768) [jsutton@samba.org Fixed conflicts in knownfails and third_party/heimdal/kdc/fast.c] Autobuild-User(v4-19-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-19-test): Wed Jul 3 09:56:13 UTC 2024 on atb-devel-224
2cf809bb -
Douglas Bagnall authored
There is no reason to think '-' and '+' are the only characters that might sneak into a vendor string; Debian habitually use '~'. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15673 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit 0bc5b6f2)
fe5f703e -
Douglas Bagnall authored
In practice there isn't a use for two options, and neither quite matched what people thought they were doing. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15673 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit 673c8e6c)
a65eda03 -
Xavi Hernandez authored
CTDB uses a queue to receive requests and send answers. It works asynchronously using the tevent framework. However there was an issue that gave priority to the receiving side so, when a request was processed and the answer posted to the queue, if another incoming request arrived, it was served before sending the previous answer. This scenario could repeat for long periods of time if the frequency of incoming requests was high enough. Eventually, a small time gap between incoming request gave a chance to process the pending output queue, sending many answers in a burst. This patch makes sure that both queues (input and output) are processed if the event contains the appropriate flag. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15678 RN: Fix unnecessary delays in CTDB while processing requests under high load. Signed-off-by: Xavi Hernandez <xhernandez@redhat.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Jul 1 09:17:43 UTC 2024 on atb-devel-224 (cherry picked from commit 60550fbe) Autobuild-User(v4-19-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-19-test): Tue Jul 9 08:46:54 UTC 2024 on atb-devel-224
6107f663 -
Stefan Metzmacher authored
This is better then requiring private runners, as we'll be able to use shared runners for ext4 soon. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit b1e83b6c)
37414481 -
Andrew Bartlett authored
At the time of this commit, GitLab shared runners tagged "gce" were 2x AMD EPYC 7B12 with 8GB ram. Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 19fb9a97)
0c14b0c9 -
Andrew Bartlett authored
This is the simplest way to keep this test environment alive. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz> (cherry picked from commit 4ae3e9b2)
e5d3231f -
Stefan Metzmacher authored
This copes with the differences between MIT 1.20 and 1.21 during gitlab pipeline selftest. We need this because Fedora 38 upgraded from 1.20.1 to 1.21. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15660 Signed-off-by: Stefan Metzmacher <metze@samba.org>
0702547d -
Andreas Schneider authored
See https://docs.gitlab.com/ee/ci/runners/hosted_runners/linux.html BUG: https://bugzilla.samba.org/show_bug.cgi?id=15660 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 84fb5cc8)
17916844 -
Andreas Schneider authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15660 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit d00e9482)
8d2c6462 -
Andreas Schneider authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15660 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit f3af6e86)
374c5ed2 -
Andreas Schneider authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15660 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 54fed589)
4180ff4e -
Andreas Schneider authored
This fixes issues with bind compiled with jemalloc. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15660 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit f88e6064)
9308c3aa -
Andreas Schneider authored
This fixes issues with bind compiled with jemalloc. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15660 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Jun 13 08:41:39 UTC 2024 on atb-devel-224 (cherry picked from commit 8ae180e1) Autobuild-User(v4-19-test): Stefan Metzmacher <metze@samba.org> Autobuild-Date(v4-19-test): Tue Jul 9 14:24:35 UTC 2024 on atb-devel-224
fee232dd -
Ralph Boehme authored
third_party/heimdal: Import lorikeet-heimdal-202407041740 (commit 42ba2a6e5dd1bc14a8b5ada8c9b8ace85956f6a0) Fix clock skew error message and memory cache clock skew recovery BUG: https://bugzilla.samba.org/show_bug.cgi?id=15676 Signed-off-by: Ralph Boehme <slow@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Fri Jul 5 10:02:26 UTC 2024 on atb-devel-224 (cherry picked from commit e4d6a19e) Autobuild-User(v4-19-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-19-test): Wed Jul 10 13:29:02 UTC 2024 on atb-devel-224
8d08c814 -
Andreas Schneider authored
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Jul 4 08:08:49 UTC 2024 on atb-devel-224 (cherry picked from commit 93a3dd48)
b22c93ac -
Pavel Filipenský authored
This is to fix the error when pushing to personal gitlab repo: 2024-07-04 08:16:05,460 Running: 'git clone --recursive --shared /builds/pfilipen/samba /builds/samba-testbase/master' in '/builds/pfilipen/samba' Cloning into '/builds/samba-testbase/master'... fatal: detected dubious ownership in repository at '/builds/pfilipen/samba/.git' To add an exception for this directory, call: git config --global --add safe.directory /builds/pfilipen/samba/.git fatal: Could not read from remote repository. Instead of adding more and more explicit repositories we should just allow any, we're in an isolated environment... BUG: https://bugzilla.samba.org/show_bug.cgi?id=15660 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Jul 10 10:35:00 UTC 2024 on atb-devel-224 (cherry picked from commit 3a21b7d9) Autobuild-User(v4-19-test): Stefan Metzmacher <metze@samba.org> Autobuild-Date(v4-19-test): Thu Jul 11 13:22:43 UTC 2024 on atb-devel-224
63c8ed2a -
Douglas Bagnall authored
The default value (30) truncates "Samba 4.21.0pre1-DEVELOPERBUILD" to "Samba 4.21.0pre1-DEVELOPE" in the bottom left corner of the man page. ("Samba 4.21.0pre1-DEVELOPE" is only 25 bytes long, not 30, but let's not worry about that). On narrow terminals (< ~75 columns) this makes it more likely that the version string will run into the date string. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15672 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit 7fb38aee)
bd365f68 -
Douglas Bagnall authored
We return true from this function when a secret has been erased, and were accidentally treating as if it had secrets. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15671 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit f3b240da)
efd989ac -
Douglas Bagnall authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit f17a2b1b) [jsutton@samba.org Fixed conflict in selftest/tests.py]
0b94b86f -
Douglas Bagnall authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit 05128a1f)
245fe4d5 -
Douglas Bagnall authored
If argv contains a secret option without an '=' (or in the case of "-U", the username is separated by space), we will get to the `if (strlen(p) == ulen) { continue; }` without resetting the found and is_user variables. This *sometimes* has the right effect, because the next string in argv ought to contain the secret. But in a case like {"--password", "1234567890"}, where the secret string is the same length as the option, we *again* take that branch and the password is not redacted, though the argument after it will be unless it is also of the same length. If we always set the flags at the start we avoid this. This makes things worse in the short term for secrets that are not the same length as their options, but we'll get to that in another commit soon. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit 2f6020cf)
22a6e455 -
Douglas Bagnall authored
We weren't treating "--password secret" the same as "--password=secret", which sometimes led to secrets not being redacted. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit 53a11845)
d87b5a97 -
Douglas Bagnall authored
Before we have been trying to cram three cases into a boolean return value: * cmdline had secrets, we burnt them -> true * cmdline had no secrets, all good -> false * cmdline has NULL string, WTF! emergency! -> false This return value is only used by Python which wants to know whether to go to the trouble of replacing the command line. If samba_cmdline_burn() returns false, no action is taken. If samba_cmdline_burn() burns a password and then hits a NULL, it would be better not to do nothing. It would be better to crash. And that is what Python will end up doing, by some talloc returning NULL triggering a MemoryError. What about the case like {"--foo", NULL, "-Ua%b"} where the secret comes after the NULL? That will still be ignored by Python, as it is by all C tools, but we are hoping that can't happen anyway. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit d3d8dffc)
0285ea8c -
Douglas Bagnall authored
As this function increases in complexity, it helps to keep things close. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit f5233ddf)
83de4276 -
Douglas Bagnall authored
We have options that start with --user or --password that we don't want to burn. Some grepping says: 2 --user1 1 --user2 10 --user-allowed-to-authenticate-from 6 --user-allowed-to-authenticate-to 2 --user-allow-ntlm-auth 25 --user-authentication-policy 1 --user-config 4 --user-domgroups 5 --user-ext-name 2 --user-groups 6 --user-info 27 --username 1 --username2 2 --userou 1 --users 2 --user-sidinfo 6 --user-sids 14 --user-tgt-lifetime-mins 2 --password2 118 --password-file 2 --password-from-stdin # from here, grepping for strings around POPT_ constants 5 "user" 2 "user1" 2 "user2" 1 "userd" 1 "user-domgroups" 1 "user-groups" 1 "user-info" 2 "username" 1 "user-sidinfo" 1 "user-sids" 1 passwordd 4 "password" Not all of these use lib/cmdline, but I think most do, via Python which defers to cmdline_burn(). Note that there are options we should burn that aren't on this list, like --adminpass. That's another matter. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit 6effed31)
c01499cd -
Douglas Bagnall authored
We have more secret arguments, like --client-password, --adminpass, so we are going to use an allowlist for options containing 'pass', but we don't want to burn the likes of --group=passionfruit. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit c4df89e9)
ae462aa7 -
Douglas Bagnall authored
We treat any option containing 'pass' with suspicion, unless we know it is OK. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit f1fbba6d)
0c7a0ff7 -
Douglas Bagnall authored
This is the long form of -U in samba-tool. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 (cherry picked from commit 63a83fb7)
bfdd8d17 -
Douglas Bagnall authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> (cherry picked from commit 97be45f9)
e35d6aeb -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 (cherry picked from commit d2b119e3)
0c6749b1 -
Douglas Bagnall authored
We burn arguments to all unknown options containing "pass" (e.g. "--passionate=false") in case they are a password option, but is bad in the case where the unknown option takes no argument but the next option *is* a password (like "--overpass --password2 barney". In that case "--password2" would be burnt and not "barney". The burning behaviour doesn't change with this commit, but users will now see an error message explaining that the option was unknown. This is not so much aimed at end users -- for who an invalid option will hopefully lead to --help like output -- but to developers who add a new "pass" option. This also slightly speeds up the processing of known password options, which is a little bit important because we are in a race to replace the command line in /proc before an attacker sees it. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15674 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org> Autobuild-Date(master): Wed Jul 10 06:28:08 UTC 2024 on atb-devel-224 (cherry picked from commit 86843685) Autobuild-User(v4-19-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-19-test): Tue Jul 23 08:43:59 UTC 2024 on atb-devel-224
2b35eab7 -
Douglas Bagnall authored
In AD_DS_Classes_Windows_Server_v1903.ldf from https://www.microsoft.com/en-us/download/details.aspx?id=23782, we see defaultSecurityDescriptor: O:BAG:BAD: (A;;RPWPCRCCDCLCLORCWOWDSDDTSW;;;DA)(A;;RPLCLORC;;;AU) BUG: https://bugzilla.samba.org/show_bug.cgi?id=15685 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org> Autobuild-Date(master): Thu Jul 25 06:27:27 UTC 2024 on atb-devel-224 (cherry picked from commit 8903876f) Autobuild-User(v4-19-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-19-test): Mon Jul 29 13:17:42 UTC 2024 on atb-devel-224
4419ccc5 -
Andreas Schneider authored
Commit 0bc5b6f2 changed the script for generating the ABI symbol version. It broke the ABI by changing all dots to underscores. This reverts the commit partially to preserve the dots in the version part. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15673 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org> Autobuild-Date(master): Tue Aug 6 00:42:56 UTC 2024 on atb-devel-224 (cherry picked from commit 46215ab1b34aa79c4c831ea1c12f73eacf1e8a12) Autobuild-User(v4-19-test): Stefan Metzmacher <metze@samba.org> Autobuild-Date(v4-19-test): Tue Aug 6 11:44:00 UTC 2024 on atb-devel-224
ab535a64 -
Jones Syue authored
Run ntlm_auth with options --lm-response/--nt-response/--challenge, and pass wrong length to these options, got error prompted logs about 'only got xxx bytes', which are not consistent with length check. This patch revise logs for length check to make it more consistent. For example --lm-response requires exact 24 hex, let us input three kinds of length 23 24 25, prompted logs said 'only got 25 bytes' seems confusing. script: for length in 23 24 25; \ do \ ntlm_auth --username=${un} --password=${pw} \ --lm-response="`openssl rand -hex ${length}`"; \ done; output: hex decode of 04db772593f5e6023d0ab4bc67a942c9179963477eb49d failed! (only got 23 bytes) NT_STATUS_OK: The operation completed successfully. (0x0) hex decode of 1e57749feb46bedcf969af6cbbe10e21d0232e35c27eb07294 failed! (only got 25 bytes) After patch it shows 'got 25 bytes, expected 24' seems more consistent: hex decode of e13e70c9cf2ac1e20015657c4bec53435b1b948febb63f failed! (got 23 bytes, expected 24) NT_STATUS_OK: The operation completed successfully. (0x0) hex decode of 64647005243092b036856f572faad262e0b69386d095d60f54 failed! (got 25 bytes, expected 24) BUG: https://bugzilla.samba.org/show_bug.cgi?id=15677 Signed-off-by: Jones Syue <jonessyue@qnap.com> Reviewed-by: David Mulder <dmulder@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Jul 6 00:52:02 UTC 2024 on atb-devel-224 (cherry picked from commit 90c9d0d9) Autobuild-User(v4-19-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-19-test): Thu Aug 15 07:56:59 UTC 2024 on atb-devel-224
af2360d6 -
Jule Anger authored
Signed-off-by: Jule Anger <janger@samba.org>
c992f748 -
Jule Anger authored
Signed-off-by: Jule Anger <janger@samba.org>
204b0f2d -
Michael Tokarev authored8b3f193e
Showing
- .gitlab-ci-main.yml 57 additions, 21 deletions.gitlab-ci-main.yml
- VERSION 1 addition, 1 deletionVERSION
- WHATSNEW.txt 102 additions, 2 deletionsWHATSNEW.txt
- auth/credentials/credentials.c 5 additions, 0 deletionsauth/credentials/credentials.c
- auth/credentials/credentials.h 1 addition, 0 deletionsauth/credentials/credentials.h
- auth/credentials/credentials_secrets.c 25 additions, 6 deletionsauth/credentials/credentials_secrets.c
- auth/credentials/tests/test_creds.c 27 additions, 10 deletionsauth/credentials/tests/test_creds.c
- bootstrap/.gitlab-ci.yml 2 additions, 4 deletionsbootstrap/.gitlab-ci.yml
- bootstrap/config.py 3 additions, 0 deletionsbootstrap/config.py
- bootstrap/generated-dists/centos8s/bootstrap.sh 3 additions, 0 deletionsbootstrap/generated-dists/centos8s/bootstrap.sh
- bootstrap/sha1sum.txt 1 addition, 1 deletionbootstrap/sha1sum.txt
- buildtools/wafsamba/samba_abi.py 3 additions, 3 deletionsbuildtools/wafsamba/samba_abi.py
- buildtools/wafsamba/samba_third_party.py 2 additions, 2 deletionsbuildtools/wafsamba/samba_third_party.py
- buildtools/wafsamba/samba_version.py 5 additions, 0 deletionsbuildtools/wafsamba/samba_version.py
- ctdb/common/ctdb_io.c 11 additions, 6 deletionsctdb/common/ctdb_io.c
- ctdb/doc/ctdb_mutex_ceph_rados_helper.7.xml 3 additions, 1 deletionctdb/doc/ctdb_mutex_ceph_rados_helper.7.xml
- ctdb/utils/ceph/ctdb_mutex_ceph_rados_helper.c 42 additions, 8 deletionsctdb/utils/ceph/ctdb_mutex_ceph_rados_helper.c
- docs-xml/xslt/man.xsl 3 additions, 0 deletionsdocs-xml/xslt/man.xsl
- lib/cmdline/cmdline.c 192 additions, 25 deletionslib/cmdline/cmdline.c
- lib/cmdline/tests/test_cmdline.c 47 additions, 7 deletionslib/cmdline/tests/test_cmdline.c