Skip to content
Snippets Groups Projects

Compare revisions

Changes are shown as if the source revision was being merged into the target revision. Learn more about comparing revisions.

Source

Select target project
No results found

Target

Select target project
  • lts-team/packages/samba
  • thctlo/samba-lintianfix
  • arnaudr/samba
  • jrwren/samba
  • paride/samba
  • athos/samba
  • henrich/samba
  • cnotin/samba
  • mimi89999/samba
  • samba-team/samba
  • ahasenack/samba
  • jrtc27/samba
  • noel/samba
13 results
Show changes
samba (2:4.19.5+dfsg-2) unstable; urgency=medium
* rename libsmbclient => libsmbclient0 for 64-bit time_t transition
Closes: #1064337
* d/libsmbclient.lintian-overrides: remove, soname now = package name
* add Breaks: of sssd packages to samba-libs
* +passchange-error-message.patch - fix password change error message
* +edns0.patch: enable EDNS0 support in internal UDP-only DNS client
https://bugzilla.samba.org/show_bug.cgi?id=15536
-- Michael Tokarev <mjt@tls.msk.ru> Wed, 28 Feb 2024 19:38:48 +0300
samba (2:4.19.5+dfsg-1) unstable; urgency=medium
* new upstream stable/bugfix release (4.19.5)
......
......@@ -144,6 +144,9 @@ Replaces:
Breaks:
libwbclient0 (<< 2:4.16.1+dfsg-7~),
samba (<< 2:4.17.0+dfsg-2~),
sssd-ad (<< 2.9.4-1+b1),
sssd-ad-common (<< 2.9.4-1+b1),
sssd-ipa (<< 2.9.4-1+b1),
Description: Samba core libraries
Samba is an implementation of the SMB/CIFS protocol for Unix systems,
providing support for cross-platform file sharing with Microsoft Windows, OS X,
......@@ -190,7 +193,7 @@ Description: Samba common files used by both the server and the client
.
This package contains the common files that are used by both the server
(provided in the samba package) and the client (provided in the smbclient
libsmbclient packages).
libsmbclient0 packages).
Package: samba-ad-dc
Architecture: all
......@@ -370,7 +373,11 @@ Description: Samba Virtual FileSystem plugins
Note: The runtime dependencies of vfs_ceph, vfs_glusterfs and vfs_snapper are
moved to Recommends.
Package: libsmbclient
Package: libsmbclient0
Provides: ${t64:Provides}
X-Time64-Compat: libsmbclient
Replaces: libsmbclient
Breaks: libsmbclient (<< ${source:Version})
Section: libs
Architecture: any
Multi-Arch: same
......@@ -385,8 +392,8 @@ Package: libsmbclient-dev
Section: libdevel
Architecture: any
Multi-Arch: same
Depends: libsmbclient (= ${binary:Version}), ${misc:Depends}
Description: development files for libsmbclient
Depends: libsmbclient0 (= ${binary:Version}), ${misc:Depends}
Description: development files for libsmbclient0
This package provides the development files (static library and headers)
required for building applications against libsmbclient, a library that
enables client applications to talk to Microsoft Windows and Samba servers
......
# changing a library package name needlessly is always worse than having a
# name that doesn't match the soname.
libsmbclient: package-name-doesnt-match-sonames libsmbclient0
From: Michael Tokarev <mjt@tls.msk.ru>
Subject: Minimal EDNS0 support for built-in DNS client
Date: Mon, 26 Feb 2024 14:15:00 +0300
Forwarded: yes
Bug: https://bugzilla.samba.org/show_bug.cgi?id=15536
Currently, samba built-in DNS client is UDP-only (it does
support TCP mode, but not all components use it). In
particular, when winbind queries list of AD DCs (SRV
record) which can be quite large, it uses UDP-only query.
And at the same time, samba DNS client does not support
EDNS0 at all, so the reply is limited to standard DNS
packet size which is 512 bytes.
Add minimal EDNS0 OPT record to ADDITIONAL section when
sending a DNS request out, indicating we can accept
DNS packets up to 4Kb in size.
Since DNSSEC is in wide use today and DNSSEC requires
EDNS0, it is okay to assume ENDS0 is widely supported
these days, so there should be no regressions when
enabling EDNS0.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
diff --git a/libcli/dns/dns.c b/libcli/dns/dns.c
index 943b4d5b33e..81144601bb8 100644
--- a/libcli/dns/dns.c
+++ b/libcli/dns/dns.c
@@ -422,6 +422,7 @@ struct tevent_req *dns_cli_request_send(TALLOC_CTX *mem_ctx,
struct dns_cli_request_state *state;
struct dns_name_question question;
struct dns_name_packet out_packet;
+ struct dns_res_rec edns0_opt;
enum ndr_err_code ndr_err;
req = tevent_req_create(mem_ctx, &state,
@@ -443,11 +444,19 @@ struct tevent_req *dns_cli_request_send(TALLOC_CTX *mem_ctx,
.question_type = qtype, .question_class = qclass
};
+ edns0_opt = (struct dns_res_rec) {
+ .name = "",
+ .rr_type = DNS_QTYPE_OPT,
+ .rr_class = 4096 /* 4096 bytes UDP buffer size */
+ };
+
out_packet = (struct dns_name_packet) {
.id = state->req_id,
.operation = DNS_OPCODE_QUERY | DNS_FLAG_RECURSION_DESIRED,
.qdcount = 1,
- .questions = &question
+ .questions = &question,
+ .arcount = 1,
+ .additional = &edns0_opt
};
ndr_err = ndr_push_struct_blob(
From: Michael Tokarev <mjt@tls.msk.ru>
Date: Mon, 26 Feb 2024 15:35:35 +0300
Subject: passchange: error message fix
Forwarded: yes
Missing space and newline.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
diff --git a/source3/libsmb/passchange.c b/source3/libsmb/passchange.c
index 716bfa39a3b..4049ad0fea1 100644
--- a/source3/libsmb/passchange.c
+++ b/source3/libsmb/passchange.c
@@ -221,8 +221,8 @@ NTSTATUS remote_password_change(const char *remote_machine,
if (!NT_STATUS_IS_OK(result)) {
int rc = asprintf(
err_str,
- "machine %s rejected to change the password"
- "with error: %s",
+ "machine %s rejected to change the password "
+ "with error: %s\n",
remote_machine,
get_friendly_nt_error_msg(result));
if (rc <= 0) {
......@@ -23,3 +23,5 @@ meaningful-error-if-no-samba-ad-provision.patch
meaningful-error-if-no-python3-markdown.patch
ctdb-use-run-instead-of-var-run.patch
silence-can-not-convert-group-sid.diff
edns0.patch
passchange-error-message.patch
......@@ -130,7 +130,7 @@ mitkrb5-samba-ver = ${DEB_VERSION}mitkrb5
mitkrb5-dep-pkgs = samba-libs samba-dev
mitkrb5-dep-pkgs += samba samba-common-bin python3-samba
mitkrb5-dep-pkgs += samba-dsdb-modules samba-vfs-modules
mitkrb5-dep-pkgs += libsmbclient smbclient
mitkrb5-dep-pkgs += libsmbclient0 smbclient
mitkrb5-dep-pkgs += libnss-winbind libpam-winbind
mitkrb5-dep-pkgs += winbind libwbclient0
mitkrb5-dep-pkgs += samba-testsuite
......@@ -373,7 +373,7 @@ endif
$(call depcheck, libldb2, samba|samba-libs|winbind|libwbclient0) # use-bzero-instead-of-memset_s.diff
$(call depcheck, python3-samba, samba|winbind|ctdb)
$(call depcheck, libwbclient0, samba|samba-libs|winbind|smbclient|ctdb)
$(call depcheck, libsmbclient, samba|winbind|smbclient|ctdb)
$(call depcheck, libsmbclient0, samba|winbind|smbclient|ctdb)
override_dh_gencontrol:
dh_gencontrol $(addprefix -p, ${LDB_PACKAGES}) -- -v${LDB_DEB_VERSION}
......