Commits on Source (31)
-
Jule Anger authored
and re-enable GIT_SNAPSHOT. Signed-off-by: Jule Anger <janger@samba.org>
7908c00d -
Andreas Schneider authored
This allows enable INFO level logging with: `samba-gpupdate -d3` BUG: https://bugzilla.samba.org/show_bug.cgi?id=15558 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 14519407)
9e946a8d -
Anoop C S authored
Commit 49b6137f switched the default to install `wspsearch` client from False to True but missed to build and install the corresponding man page. Therefore adding wspsearch.1 to the list of man pages to be built and installed by default. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15565 Signed-off-by: Anoop C S <anoopcs@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Tue Jan 30 14:38:58 UTC 2024 on atb-devel-224 (cherry picked from commit a48f8ae3) Autobuild-User(v4-20-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-20-test): Mon Feb 5 14:05:01 UTC 2024 on atb-devel-224
59365287 -
Douglas Bagnall authored
We are looking at an optimisation for non-object ACEs, which are more common, but these tests are overwhelmed by object (OA) ACEs. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit d5371f6b)
daf5b5f5 -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit e8026117)
66fa6885 -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit d25fe244)
7f0bdf2b -
Douglas Bagnall authored
This includes removing the ANCIENT_SAMBA switch for pre-4.3, as nobody cares anymore and many tests would not run correctly anyway. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit ceb53892)
1287f182 -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit 2f685450)
14edd0fd -
Douglas Bagnall authored
The idea was to get a less jittery idea of the underlying noise, but ut is still almost instant. This I suppose is useful in indicating that this much of the test has very little overhead. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit 93e6ea4c)
fb49ce47 -
Douglas Bagnall authored
This is worth changing, because having a server running in the background can only add noise to the results. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit 5fa66376)
b5289d66 -
Douglas Bagnall authored
For security_ace_coda in security.idl, the sub-context size is involves a slightly non-trivial function call which returns a constant value. In all other cases, a constant expression is used, and this makes no difference. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit 98117627)
f8014cae -
Douglas Bagnall authored
This was manual until commit c73034cf (a few months ago). Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit 1e6a876c)
8787185a -
Douglas Bagnall authored
The overwhelmingly common case is that there are no bytes left, and regardless of the ACE type we want to store an empty blob. We know the blob will be empty if there are no bytes, so we don't need to allocate a sub-ndr and tokens list and so forth. This can save almost half the time of a security descriptor pull. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit ac0c8ee0)
c9974e62 -
Douglas Bagnall authored
This will allow some optimisations; in this commit we just copy the code. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit dc08e792)
e4cf11b1 -
Douglas Bagnall authored
We don't expect an ordinary ACE to have a non-empty coda, and we don't really want to push it if it does, but for this patch we still will. This will not change the data on the wire. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit ee1b8ae0)
e61d4476 -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit c2673b02)
5d0d17a9 -
Douglas Bagnall authored
This might have little effect, but sometimes we see primatives like ndr_pull_uint32() taking a few percent of the CPU time, and this is in all those functions. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit 4face258)
d4547daf -
Douglas Bagnall authored
From 1e80221b (2008) until c73034cf (conditional ACEs, etc, 2023) we had a manual ndr_pull_security_ace() that would discard trailing bytes, which are those bytes that we now call the coda. The ACE types that we handled then are those that end up with a coda.ignored data blob. With this we effectively restore the long-standing behaviour in the event that we push and pull an ACE -- though now we discard the ignored bytes on push rather than pull. This change is not because the trailing bytes caused any problems (as far as is known), but because it is much faster to not do the push. It may be that such ACEs no longer occur. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit 2a60ec98)
5c0f6a20 -
Douglas Bagnall authored
When an ACE is not an object ACE, which is common, setting the switch value and attempting the object ACE GUID pull is just going to do nothing, and we know that ahead of time. By noticing that we can save a bit of time on a common operation. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit fce4d51e)
276e67fe -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit ecb5da3e)
48084786 -
Douglas Bagnall authored
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit a72c1989)
0f81aec9 -
Douglas Bagnall authored
This returns the behaviour with ordinary ACEs to where it was with 4.19. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15574 (cherry picked from commit 0c1f421c)
7f338d61 -
Douglas Bagnall authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15566 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
8e8b8fc0 -
Douglas Bagnall authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15566 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
4872b0ab -
Andrew Bartlett authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15566 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(v4-20-test): Jule Anger <janger@samba.org> Autobuild-Date(v4-20-test): Mon Feb 12 11:55:51 UTC 2024 on atb-devel-224
f8dfce94 -
Jule Anger authored
Signed-off-by: Jule Anger <janger@samba.org>
f06a06b7 -
Jule Anger authored
Signed-off-by: Jule Anger <janger@samba.org>
0167b75a -
Michael Tokarev authored6d67fdfc
-
Michael Tokarev authored
Update to upstream version '4.20.0~rc2+dfsg' with Debian dir db499c073b8f2c6e097e149ee6b798db30c8d38c
a771d975 -
Michael Tokarev authored81b023b5
-
Michael Tokarev authoreda97fd437
Showing
- VERSION 1 addition, 1 deletionVERSION
- WHATSNEW.txt 99 additions, 1 deletionWHATSNEW.txt
- debian/changelog 8 additions, 0 deletionsdebian/changelog
- debian/not-installed 1 addition, 0 deletionsdebian/not-installed
- docs-xml/wscript_build 1 addition, 0 deletionsdocs-xml/wscript_build
- librpc/idl/security.idl 1 addition, 1 deletionlibrpc/idl/security.idl
- librpc/ndr/libndr.h 1 addition, 1 deletionlibrpc/ndr/libndr.h
- librpc/ndr/ndr_basic.c 6 additions, 0 deletionslibrpc/ndr/ndr_basic.c
- librpc/ndr/ndr_sec_helper.c 106 additions, 1 deletionlibrpc/ndr/ndr_sec_helper.c
- pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm 3 additions, 2 deletionspidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
- python/samba/gp/util/logging.py 3 additions, 2 deletionspython/samba/gp/util/logging.py
- selftest/perf_tests.py 2 additions, 2 deletionsselftest/perf_tests.py
- source4/dsdb/tests/python/ndr_pack_performance.py 57 additions, 64 deletionssource4/dsdb/tests/python/ndr_pack_performance.py